Re: [PATCH 0/4] editorial: Prepare master branch for 1.4 spec release

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Oct 30, 2025 at 03:15:09PM +0000, Parav Pandit wrote:
> 
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: 30 October 2025 04:30 PM
> > 
> > On Thu, Oct 30, 2025 at 10:54:53AM +0000, Parav Pandit wrote:
> > >
> > >
> > > > From: Michael S. Tsirkin <mst@redhat.com>
> > > > Sent: 27 October 2025 11:38 PM
> > > >
> > > > On Mon, Oct 27, 2025 at 06:04:22PM +0000, Parav Pandit wrote:
> > > > >
> > > > >
> > > > > > From: Michael S. Tsirkin <mst@redhat.com>
> > > > > > Sent: 27 October 2025 11:27 PM
> > > > > >
> > > > > > On Mon, Oct 27, 2025 at 07:47:52PM +0200, Parav Pandit wrote:
> > > > > > > Hi All,
> > > > > > >
> > > > > > > This short series prepares the specification for release 1.4
> > > > > > > version from the master branch.
> > > > > >
> > > > > >
> > > > > > I noticed you updated latexdiff module - intentional?
> > > > > >
> > > > > I didn't. :(
> > > > > Latexdiff is able to generate the necessary diff without my
> > > > > changelog
> > > > patches.
> > > >
> > > > we have this so it should not be in the diff
> > > >
> > > > \begin{DIFnomarkup}
> > > > \begin{longtable}{ | p{0.15\textwidth} | p{0.05\textwidth} |
> > > > p{0.1\textwidth}
> > > > | p{0.70\textwidth} | } \hline \textbf{Revision} & \textbf{Date} &
> > > > \textbf{Editor} & \textbf{Changes Made} \\ \hline \endhead %\lbrack
> > > > Rev number \rbrack & \lbrack Rev Date \rbrack & \lbrack Modified By
> > > > \rbrack & \lbrack Summary of Changes \rbrack \\ %\hline
> > > > \input{cl-os.tex} & & \\ \hline \end{longtable} \end{DIFnomarkup}
> > > >
> > > Its puzzling. Because when I bisect, after removing the changelog related
> > patches, makediffpdf.sh progresses fine.
> > >
> > > The error likely seems be the 'overfull' part below.
> > >
> > > Overfull \hbox (1.18391pt too wide) in paragraph at lines 25449--25450
> > > \TU/lmss/m/n/10 MUST set the \TU/lmss/m/sl/10 leap_-second_-smearing
> > > \TU/lmss/m /n/10 field to VIRTIO_-RTC_-SMEAR_-UNSPECIFIED,
> > > VIRTIO_-RTC_-SMEAR_-
> > >
> > > Couldn't try latest latextdiff yet.
> > 
> > 
> > play with the generated diff. it's quite readable.
> > 
> 
> Ok. My bisection was wrong.
> It's the RTC complain.
> Latexdiff does not like below line during diff generation.
> 
> For VIRTIO_RTC_REQ_CLOCK_CAP, and clock types other than
> VIRTIO_RTC_CLOCK_UTC_SMEARED, the device MUST set the
> \field{leap_second_smearing} field to VIRTIO_RTC_SMEAR_UNSPECIFIED.


I am guessing it is not latexdiff, but xetex not liking what
latextdiff generated?

So again, look at virtio-diff.tex and see what is in
the generated diff you are trying to compile.
What you pasted here is the original tex.





> Error:
> Overfull \hbox (1.18391pt too wide) in paragraph at lines 25449--25450
> \TU/lmss/m/n/10 MUST set the \TU/lmss/m/sl/10 leap_-second_-smearing \TU/lmss/m
> /n/10 field to VIRTIO_-RTC_-SMEAR_-UNSPECIFIED, VIRTIO_-RTC_-SMEAR_-
> 
> This error is similar to the fixes you made in past in below commit.
> But this time it is not in the label. It in the usual text itself.
> There is so much of similar text like above.
> 
> commit 6c2340547951ada46447c973b1d8133165785840
> Author: Michael S. Tsirkin <mst@redhat.com>
> Date:   Mon Jul 15 12:50:05 2024 -0400
> 
>     admin: get rid of _ in labels
> 
>     it's not the 1st time we find out underscores in labels confuse
>     latexdiff machinery when generating html.
>     Errors look like this:
> 
>     ! Missing \endcsname inserted.
>     <to be read again>
>                        \unhbox
>     ....
> 
>     ?
>     ! Emergency stop.
>     <to be read again>
>                        \unhbox
> 
>     To fix, convert underscores in labels to dashes.
> 
>     Message-Id: <3e773fcfd4246e66e6f39d3be95d2c0335e34532.1721062136.git.mst@redhat.com>
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> > >
> > > >
> > > >
> > > > > Below is the version I am using for last sometime.
> > > > >
> > > > > latexdiff --version
> > > > > This is LATEXDIFF 1.3.1a  (Algorithm::Diff 1.15 fast, Perl v5.34.0)
> > > > >   (c) 2004-2018 F J Tilmann
> > > > >
> > > > >
> > > > > > > note:
> > > > > > > makediffpdf.sh still have fails and needs resolution. WIP.
> > > > > > >
> > > > > > > Parav Pandit (4):
> > > > > > >   edit: remove old changelog
> > > > > > >   edit: add changelog for 1.4
> > > > > > >   edit: Remove annotation of special character
> > > > > > >   REVISION: update to 1.4
> > > > > > >
> > > > > > >  REVISION      |    2 +-
> > > > > > >  REVISION-DATE |    2 +-
> > > > > > >  cl-cs05.tex   | 2120 ++++++++++++++++++++++++++++++++++++++++
> > > > > > >  cl-os.tex     | 2605 ++++++++++++++++++++++++-------------------------
> > > > > > >  4 files changed, 3407 insertions(+), 1322 deletions(-)
> > > > > > > create mode
> > > > > > > 100644 cl-cs05.tex
> > > > > > >
> > > > > > > --
> > > > > > > 2.34.1