From: "Michael S. Tsirkin" <mst@redhat.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Linlin Zhang <linlin.zhang@oss.qualcomm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
virtio-comment@lists.linux.dev, ebiggers@kernel.org,
neeraj.soni@oss.qualcomm.com, parav@nvidia.com
Subject: Re: [PATCH v3 0/2] virtio-blk: Add inline encryption support
Date: Wed, 14 Oct 2026 04:47:04 -0400 [thread overview]
Message-ID: <20261014043959-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d503aee0-9920-4c0b-b9a0-c08e505cc3ea@nvidia.com>
On Tue, Oct 13, 2026 at 02:12:09AM +0300, Max Gurtovoy wrote:
> > Random device specific commands - I am not sure we want that.
> > It remains to be proven.
>
> Admin vq was added for mgmt/control/admin/non-DATA_IO operations.
>
> Fundamentally, it does not make sense to force random device to create new
> control VQ since we already defined admin VQs for this purpose.
>
> We could have introduced control VQ on each device type, but we didn't.
The feature is still pci specific sadly, even after X years.
The instrastructure is just not there for all transports.
I do not think it is reasonable to ask new contributors
to build such amount of infrastructure, where even experienced ones
seem to struggle.
--
MST
prev parent reply other threads:[~2026-10-14 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260913161628.368484-1-linlin.zhang@oss.qualcomm.com>
[not found] ` <20260917210841.GD331587@fedora>
[not found] ` <2f9affb3-0d1b-4469-9a66-ba052d2d1b6a@oss.qualcomm.com>
[not found] ` <20260922131442.GB18339@fedora>
[not found] ` <3a933df3-dff7-4ef3-a120-4c6e22c1fcc1@oss.qualcomm.com>
[not found] ` <de535820-591b-40f2-b840-d987c3253765@nvidia.com>
[not found] ` <9515779b-a6da-407f-99f2-011e51683d15@oss.qualcomm.com>
[not found] ` <20261008060644-mutt-send-email-mst@kernel.org>
[not found] ` <d503aee0-9920-4c0b-b9a0-c08e505cc3ea@nvidia.com>
[not found] ` <426abc9a-c7b4-4631-a5fe-3b2bba1d0414@oss.qualcomm.com>
[not found] ` <SJ0PR12MB68060279EA2241FAEB2EDE8CDC9D2@SJ0PR12MB6806.namprd12.prod.outlook.com>
2026-10-14 4:12 ` [PATCH v3 0/2] virtio-blk: Add inline encryption support Parav Pandit
2026-10-14 8:47 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014043959-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ebiggers@kernel.org \
--cc=linlin.zhang@oss.qualcomm.com \
--cc=mgurtovoy@nvidia.com \
--cc=neeraj.soni@oss.qualcomm.com \
--cc=parav@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox