Re: [PATCH v1] virtio-net: Fix to avoid using reserved feature bits

[Cornelia Huck <cohuck@redhat.com>]

On Sun, Jan 26 2025, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Sun, Jan 26, 2025 at 04:44:51PM +0000, Parav Pandit wrote:
>> 
>> 
>> > From: Michael S. Tsirkin <mst@redhat.com>
>> > Sent: Sunday, January 26, 2025 2:50 PM
>> > 
>> > On Sun, Jan 26, 2025 at 08:20:58AM +0200, Parav Pandit wrote:
>> > > Listed patches in the fixes tag, incorrectly used the reserved feature bits.
>> > > Fix them to use the well defined device specific range.
>> > >
>> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/212
>> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/213
>> > > Fixes: 8cd457d8aa82 ("virtio-net: define UDP tunnel segmentation
>> > > offload feature")
>> > > Fixes: 3fea589bd7c6 ("virtio-net: define UDP tunnel checksum offload
>> > > feature")
>> > 
>> > 
>> > Well the hashes will be wrong I think.
>> I pulled the patches from the mailing list to local repo using b4.
>> Once the new fix is voted, I will merge both the series together so that hashes stays the same.
>
> ok. just make sure to verify them before you push.
>
>> > So, we can do the ballot for this fixup, and wait with applying the patches
>> > until that new ballot completes.
>> Yes. The small fix is reviewed by Paolo and Cornelia, so if it looks ok, we can wait for this week for any additional review comments.
>> And merge by Feb-10 or so after new ballot completes.
>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

As I don't see this change as particularly contentious, I'd suggest to
just go ahead and start the voting process -- there's plenty of time to
voice concerns while the ballot is open.