[PULL v2] administration commands for device parts

[PULL v2] administration commands for device parts

[Parav Pandit]

Hi Michael, Cornelia,

The following changes since commit 9b3129fe72360a78e76b6dd890d3abc5a45fa915:

  virtio_pci_cap64: specify offset_hi, length_hi endianness (2024-07-12 06:43:53 -0400)

are available in the Git repository at:

  https://github.com/paravmellanox/virtio-spec.git tags/for_1.4_v2

for you to fetch changes up to 5b1ed863cf9701e110042e9e85d69acd06cd33c5:

  editorial: replace hyperref with ref (2024-07-12 16:08:59 +0300)

----------------------------------------------------------------
This tag contains administration commands for device parts

changelog:
v1->v2:
- fixed hyper reference to name reference
- fixed typo in commit log
- reduced the patches of pull request due to rebase of virtio-1.4 branch
v0->v1:
- resolved merge conflict for an empty line in newdevice.tex
----------------------------------------------------------------
Parav Pandit (6):
      admin: Add theory of operation for device parts
      admin: Extend resource objects for sr-iov group type
      admin: Add admin commands for device parts
      admin: Define common device parts
      admin: Add requirements of device parts commands
      editorial: replace hyperref with ref

 admin-cmds-capabilities.tex     |  16 ++
 admin-cmds-device-parts.tex     | 469 ++++++++++++++++++++++++++++++++++++++++
 admin-cmds-resource-objects.tex |  29 ++-
 admin.tex                       |  12 +-
 conformance.tex                 |   2 +
 content.tex                     |   1 +
 device-parts.tex                | 232 ++++++++++++++++++++
 newdevice.tex                   |  24 +-
 8 files changed, 778 insertions(+), 7 deletions(-)
 create mode 100644 admin-cmds-device-parts.tex
 create mode 100644 device-parts.tex

Re: [PULL v2] administration commands for device parts

[Cornelia Huck]

On Fri, Jul 12 2024, Parav Pandit <pandit.parav@gmail.com> wrote:

> Hi Michael, Cornelia,
>
> The following changes since commit 9b3129fe72360a78e76b6dd890d3abc5a45fa915:
>
>   virtio_pci_cap64: specify offset_hi, length_hi endianness (2024-07-12 06:43:53 -0400)
>
> are available in the Git repository at:
>
>   https://github.com/paravmellanox/virtio-spec.git tags/for_1.4_v2
>
> for you to fetch changes up to 5b1ed863cf9701e110042e9e85d69acd06cd33c5:
>
>   editorial: replace hyperref with ref (2024-07-12 16:08:59 +0300)
>
> ----------------------------------------------------------------
> This tag contains administration commands for device parts
>
> changelog:
> v1->v2:
> - fixed hyper reference to name reference
> - fixed typo in commit log
> - reduced the patches of pull request due to rebase of virtio-1.4 branch
> v0->v1:
> - resolved merge conflict for an empty line in newdevice.tex
> ----------------------------------------------------------------
> Parav Pandit (6):
>       admin: Add theory of operation for device parts
>       admin: Extend resource objects for sr-iov group type
>       admin: Add admin commands for device parts
>       admin: Define common device parts
>       admin: Add requirements of device parts commands
>       editorial: replace hyperref with ref

The last patch does not have the changelog cut off from the patch
description (not sure why.) Also, shouldn't it have the message id of
the mail you sent to the ML?

>
>  admin-cmds-capabilities.tex     |  16 ++
>  admin-cmds-device-parts.tex     | 469 ++++++++++++++++++++++++++++++++++++++++
>  admin-cmds-resource-objects.tex |  29 ++-
>  admin.tex                       |  12 +-
>  conformance.tex                 |   2 +
>  content.tex                     |   1 +
>  device-parts.tex                | 232 ++++++++++++++++++++
>  newdevice.tex                   |  24 +-
>  8 files changed, 778 insertions(+), 7 deletions(-)
>  create mode 100644 admin-cmds-device-parts.tex
>  create mode 100644 device-parts.tex

RE: [PULL v2] administration commands for device parts

[Parav Pandit]

> From: Cornelia Huck <cohuck@redhat.com>
> Sent: Friday, July 12, 2024 8:02 PM
> To: Parav Pandit <pandit.parav@gmail.com>; virtio-comment@lists.linux.dev;
> mst@redhat.com
> Cc: Parav Pandit <parav@nvidia.com>
> 
> On Fri, Jul 12 2024, Parav Pandit <pandit.parav@gmail.com> wrote:
> 
> > Hi Michael, Cornelia,
> >
> > The following changes since commit
> 9b3129fe72360a78e76b6dd890d3abc5a45fa915:
> >
> >   virtio_pci_cap64: specify offset_hi, length_hi endianness
> > (2024-07-12 06:43:53 -0400)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/paravmellanox/virtio-spec.git tags/for_1.4_v2
> >
> > for you to fetch changes up to
> 5b1ed863cf9701e110042e9e85d69acd06cd33c5:
> >
> >   editorial: replace hyperref with ref (2024-07-12 16:08:59 +0300)
> >
> > ----------------------------------------------------------------
> > This tag contains administration commands for device parts
> >
> > changelog:
> > v1->v2:
> > - fixed hyper reference to name reference
> > - fixed typo in commit log
> > - reduced the patches of pull request due to rebase of virtio-1.4
> > branch
> > v0->v1:
> > - resolved merge conflict for an empty line in newdevice.tex
> > ----------------------------------------------------------------
> > Parav Pandit (6):
> >       admin: Add theory of operation for device parts
> >       admin: Extend resource objects for sr-iov group type
> >       admin: Add admin commands for device parts
> >       admin: Define common device parts
> >       admin: Add requirements of device parts commands
> >       editorial: replace hyperref with ref
> 
> The last patch does not have the changelog cut off from the patch description
> (not sure why.) 
I don't know either.
I see it following.
commit 5b1ed863cf9701e110042e9e85d69acd06cd33c5 (HEAD -> virtio-1.4, tag: for_1.4_v2, origin/virtio-1.4)
Author: Parav Pandit <pandit.parav@gmail.com>
Date:   Fri Jul 12 07:14:33 2024 +0300

    editorial: replace hyperref with ref

    Replace hyperreference with the name reference.
    Fix the broken reference link for the DEVICE_STATUS part.

    Suggested-by: Michael S. Tsirkin <mst@redhat.com>
    Signed-off-by: Parav Pandit <parav@nvidia.com>

    ---
    changelog:
    v0->v1:
    - this is a fixup patch to fix the editorial changes to
      drop hyper reference and fix one broken link.
    - This is based on virtio-1.4 branch + admin parts patches
    - fixed comments from Michael
    - fixed typo of reference
    - replaced table reference as named reference for better reading
      and direct reference

> Also, shouldn't it have the message id of the mail you sent to the ML?
This is complicated flow being asked.
What is asked is:

1. Send a patch on top of patches not yet merged with commit ids of those from local tree.
2. Once it is on the mailing list; pick the message-id of it and modify the local patch!!
3. Now send the PR with this modified patch commit log which is different than what is posted on mailing list..

Please...

Can I please PR with just the 5 patches, and we apply the fixes on top after its merge?
It is at least less error prone to me to follow. It simplifies the flow for everyone ( at least it simplifies for me and rest of the revies).
We may more fixes on top of these PR anyway by multiple people.

> 
> >
> >  admin-cmds-capabilities.tex     |  16 ++
> >  admin-cmds-device-parts.tex     | 469
> ++++++++++++++++++++++++++++++++++++++++
> >  admin-cmds-resource-objects.tex |  29 ++-
> >  admin.tex                       |  12 +-
> >  conformance.tex                 |   2 +
> >  content.tex                     |   1 +
> >  device-parts.tex                | 232 ++++++++++++++++++++
> >  newdevice.tex                   |  24 +-
> >  8 files changed, 778 insertions(+), 7 deletions(-)  create mode
> > 100644 admin-cmds-device-parts.tex  create mode 100644
> > device-parts.tex