[virtio-comment] RE: [PATCH v6 0/5] virtio-net: Support flow filter for receive packets

[Cornelia Huck <cohuck@redhat.com>]

On Mon, Nov 20 2023, Parav Pandit <parav@nvidia.com> wrote:

> Hi Cornelia, Michael,
>
>
>> -----Original Message-----
>> From: Parav Pandit <parav@nvidia.com>
>> Sent: Friday, November 10, 2023 6:09 PM
>> To: virtio-comment@lists.oasis-open.org; mst@redhat.com;
>> cohuck@redhat.com
>> Cc: sburla@marvell.com; Shahaf Shuler <shahafs@nvidia.com>; si-
>> wei.liu@oracle.com; xuanzhuo@linux.alibaba.com; Parav Pandit
>> <parav@nvidia.com>
>> Subject: [PATCH v6 0/5] virtio-net: Support flow filter for receive packets
>> 
>> Summary:
>> ========
>> This series improves virtio net receive packet steering to forward/steer packets
>> to specific RQ.
>> 
>> This basic functionality will enable Linux ethtool steering, Accelerated receive
>> flow steering (ARFS) as starting point, and more use cases in future.
>> 
>> Problem statement:
>> ==================
>> Currently packet allow/drop interface has few limitations.
>> 
>> 1. Driver cannot add or delete an individual entry for mac and vlan.
>> 2. Driver cannot select mac+vlan combination for which
>>     to allow/drop packet.
>> 3. Driver cannot not set other commonly used packet match fields
>>     such as IP header fields, TCP, UDP, SCP header fields.
>> 4. Driver cannot steer specific packets based on the match
>>    fields to specific receiveq.
>> 5. Driver do not have multiple or dedicated virtqueues to
>>     perform flow filter requests in accelerated manner in
>>     the device.
>> 
>> Solution:
>> =========
>> Flow filter as a generic framework to overcome above limitations.
>> 
>> Overview:
>> =========
>> A flow filter defines the flow based on one or more match fields of the packet,
>> defines an action like drop/forward to RQ.
>> 
>> The flow filters are organized in flow filter groups so that their processing can be
>> ordered when multiple applications wants to use it.
>> 
>> Flow filters requests can be transported via control vq or dedicated flow filter
>> virtqueue so that it does not get intermixed with other slow operations of cvq.
>> 
>> Flow filter requirements addressed by this series is worked by virtio community
>> at [1].
>> 
>> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/179
>> 
>
> Now that this has been mature phase and on list for several weeks,
> I updated the github to point to v6.
>
> Can you please start the voting process?

I don't feel like I'm capable of judging the networking parts, but I
have a couple of wording suggestions (things like definite articles
etc.) Would you prefer a respin, or a vote now and an editorial patch on
top? I can either comment now, or start voting.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/