Re: [PATCH v11 0/4] virtio-net: define UDP tunnel offload

Paolo Abeni
2025-01-14T15:57:54Z

On 1/14/25 4:16 PM, Michael S. Tsirkin wrote:
> On Tue, Jan 14, 2025 at 04:04:35PM +0100, Paolo Abeni wrote:
>> On 11/27/24 10:48 AM, Paolo Abeni wrote:
>>> On 11/27/24 10:36, Paolo Abeni wrote:
>>>> UDP tunnel usage is ubiquitous in container deployment, and the ability
>>>> to offload UDP encapsulated GSO traffic impacts greatly the performances
>>>> and the CPU utilization of such use cases.
>>>>
>>>> This series includes:
>>>> - clarifications on the current semantic of NEEDS_CSUM offload
>>>> (patch 1) and DATA_VALID offload (patch 2) to make later changes easier
>>>> to follow,
>>>> - new features definition to handle both UDP tunnel segmentation
>>>> offload (patch 3).
>>>> - new features definition to handle UDP tunnel outer checksum offload
>>>> (patch 4).
>>>>
>>>> A PoC implementation is available here:
>>>>
>>>> https://github.com/pabeni/linux-devel/commits/virtio_tunnel_gso_v10/
>>>> https://github.com/pabeni/qemu/tree/virtio_tunnel_gso_v9
>>>>
>>>> Note that both implementations has not been updated since the previous
>>>> iteration, since there are no additional functional changes in v11.
>>>>
>>>> Changes from v10:
>>>> - added patch 2
>>>> - clarified only a single encapsulation level is supported (patch 3)
>>>> - s/TCP or UDP GSO packets/GSO packets/ (patch 3)
>>>> - 'to the outer UDP pseudo header' -> 'to the outer UDP pseudo header
>>>> checksum' (patch 4)
>>>> https://lore.kernel.org/virtio-comment/cover.1731084277.git.pabeni@redhat.com/
>>
>> I understand all the points under discussion have been addressed. I'm
>> wondering the next steps are and what I could do to move things forward.
>>
>> Thanks,
>>
>> Paolo
>
> See
> https://github.com/oasis-tcs/virtio-spec?tab=readme-ov-file#use-of-github-issues
>
> for the process to get a change merged once there is concensus.

Thank you for the prompt reply and useful guidance.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/212

Could please open a voting ballot for these changes?

Thanks,

Paolo