Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: virtio-comment@lists.oasis-open.org
Cc: Yang Huang <yang.huang@intel.com>, Bing Zhu <bing.zhu@intel.com>,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: [virtio-comment] Clarifying the language of VIRTIO_RPMB_REQ_PROGRAM_KEY
Date: Fri, 12 Jun 2020 16:40:53 +0100	[thread overview]
Message-ID: <87sgf0nvga.fsf@linaro.org> (raw)


Hi,

In the virtio-rpmb part of the spec it says:

  The operation of a virtio RPMB device is driven by the requests placed on the virtqueue.
    The type of request can be program key (VIRTIO_RPMB_REQ_PROGRAM_KEY),
    get write counter (VIRTIO_RPMB_REQ_GET_WRITE_COUNTER),
    write (VIRTIO_RPMB_REQ_DATA_WRITE), and read (VIRTIO_RPMB_REQ_DATA_READ).
    A program key or write request can also combine with a
    result read (VIRTIO_RPMB_REQ_RESULT_READ) for a returned result.

but later on:

  VIRTIO_RPMB_REQ_RESULT_READ
     requests for a returned result. It is used following with VIRTIO_RPMB_REQ_PROGRAM_KEY or VIRTIO_RPMB_REQ_DATA_WRITE request types for a returned result in one or multiple RPMB frames. If it’s not requested, the device will not return result frame to the driver.

So which is it? I can't quite see how a VIRTIO_RPMB_REQ_RESULT_READ can
be combined with the other requests because they are not overlapping
bits so maybe the working should be:

  A program key or write request can be followed by a result read (VIRTIO_RPMB_REQ_RESULT_READ) for a returned result.

Is that is what is intended?

-- 
Alex Bennée

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


             reply	other threads:[~2020-06-12 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 15:40 Alex Bennée [this message]
2020-06-12 15:59 ` [virtio-comment] RE: Clarifying the language of VIRTIO_RPMB_REQ_PROGRAM_KEY Huang, Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgf0nvga.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bing.zhu@intel.com \
    --cc=tomas.winkler@intel.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=yang.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox