Re: [virtio-comment] [PATCH V2 1/2] virtio: introduce virtqueue state as basic facility

[Jason Wang <jasowang@redhat.com>]

在 2021/3/24 下午5:35, Stefan Hajnoczi 写道:
> On Wed, Mar 24, 2021 at 04:15:55PM +0800, Jason Wang wrote:
>> 在 2021/3/23 下午6:27, Stefan Hajnoczi 写道:
>>> On Mon, Mar 22, 2021 at 11:47:16AM +0800, Jason Wang wrote:
>>>> +
>>>> +\devicenormative{\subsection}{Virtqueue State}{Basic Facilities of a Virtio Device / Virtqueue State}
>>>> +
>>>> +If VIRTIO_F_QUEUE_STATE has been negotiated, a device MUST NOT clear
>>>> +the queue state upon reset and MUST reset the queue state when the
>>>> +driver sets ACKNOWLEDGE status bit.
>>> I only see normative sections mentioning getting the virtqueue state but
>>> not setting it. Please explain how setting works.
>>
>> You mean the device normative part? I think the description of avail state
>> and used state can explain itself. Or I miss something?
> Oops, I missed the earlier normative section that says the driver must
> set the virtqueue state after FEATURES_OK but before DRIVER_OK.
>
> When re-reading I noticed that there is a typo: s/FEATURE_OK/FEATURES_OK/.


Will fix.

Thanks


>
> Stefan


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/