[PATCH v1] virtio-net: Rename selectors_limit to classifiers_limit

[PATCH v1] virtio-net: Rename selectors_limit to classifiers_limit

[Parav Pandit]

A classifier object consists of one or more selectors. The number of
selectors per classifier object is already annotated in the field
selectors_per_classifier_limit.

The field selectors_limit is intended to reflect the limit of
classifier objects. Hence, rename it to classifiers_limit.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/215
Fixes: 3b7b7371dbed ("virtio-net: Add flow filter device and driver requirements")
Fixes: 899bb0ca24d8 ("virtio-net: Add flow filter capability")
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v0->v1:
- fixed to replace description of selectors to classifiers
---
 device-types/net/description.tex | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index b546cd7..21bb548 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -2957,7 +2957,7 @@ \subsubsection{Flow filter}\label{sec:Device Types / Network Device / Device Ope
 \begin{lstlisting}
 struct virtio_net_ff_cap_data {
         le32 groups_limit;
-        le32 selectors_limit;
+        le32 classifiers_limit;
         le32 rules_limit;
         le32 rules_per_group_limit;
         u8 last_rule_priority;
@@ -2965,8 +2965,8 @@ \subsubsection{Flow filter}\label{sec:Device Types / Network Device / Device Ope
 };
 \end{lstlisting}
 
-\field{groups_limit}, and \field{selectors_limit} represent the maximum
-number of flow filter groups and selectors, respectively, that the driver can create.
+\field{groups_limit}, and \field{classifiers_limit} represent the maximum
+number of flow filter groups and classifiers, respectively, that the driver can create.
  \field{rules_limit} is the maximum number of
 flow fiilter rules that the driver can create across all the groups.
 \field{rules_per_group_limit} is the maximum number of flow filter rules that the driver
@@ -3310,7 +3310,7 @@ \subsubsection{Flow filter}\label{sec:Device Types / Network Device / Device Ope
 command VIRTIO_ADMIN_CMD_RESOURCE_OBJ_CREATE when the resource \field{type} is
 VIRTIO_NET_RESOURCE_OBJ_FF_CLASSIFIER, if the number of flow filter selector
 objects in the device exceeds the configured driver capability
-\field{selectors_limit}.
+\field{classifiers_limit}.
 
 The device SHOULD set \field{status} to VIRTIO_ADMIN_STATUS_EBUSY for the
 command VIRTIO_ADMIN_CMD_RESOURCE_OBJ_DESTROY for a flow filter group when
-- 
2.34.1

Re: [PATCH v1] virtio-net: Rename selectors_limit to classifiers_limit

[Matias Ezequiel Vara Larsen]

On Sat, Feb 15, 2025 at 08:11:58AM +0200, Parav Pandit wrote:
> A classifier object consists of one or more selectors. The number of
> selectors per classifier object is already annotated in the field
> selectors_per_classifier_limit.
> 
> The field selectors_limit is intended to reflect the limit of
> classifier objects. Hence, rename it to classifiers_limit.
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/215
> Fixes: 3b7b7371dbed ("virtio-net: Add flow filter device and driver requirements")
> Fixes: 899bb0ca24d8 ("virtio-net: Add flow filter capability")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> changelog:
> v0->v1:
> - fixed to replace description of selectors to classifiers
> ---
>  device-types/net/description.tex | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>

RE: [PATCH v1] virtio-net: Rename selectors_limit to classifiers_limit

[Parav Pandit]

Hi,

> From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Sent: Monday, February 17, 2025 8:36 PM
> 
> On Sat, Feb 15, 2025 at 08:11:58AM +0200, Parav Pandit wrote:
> > A classifier object consists of one or more selectors. The number of
> > selectors per classifier object is already annotated in the field
> > selectors_per_classifier_limit.
> >
> > The field selectors_limit is intended to reflect the limit of
> > classifier objects. Hence, rename it to classifiers_limit.
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/215
> > Fixes: 3b7b7371dbed ("virtio-net: Add flow filter device and driver
> > requirements")
> > Fixes: 899bb0ca24d8 ("virtio-net: Add flow filter capability")
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> > changelog:
> > v0->v1:
> > - fixed to replace description of selectors to classifiers
> > ---
> >  device-types/net/description.tex | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> 
> Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>

Can you please open a voting ballot for this change?
The github link is: https://github.com/oasis-tcs/virtio-spec/issues/215
Fix link: https://lore.kernel.org/virtio-comment/Z7NQSyMUPunN5a+n@fedora/T/#m9645510b9ce09e47c8b7b2812024e6e0c71fb061