[PATCH v2] README.md: add example email for TC vote request

[PATCH v2] README.md: add example email for TC vote request

[Matias Ezequiel Vara Larsen]

Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
---
v1 -> v2: add Subject and To
---
 README.md | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index c06caf6..731838b 100644
--- a/README.md
+++ b/README.md
@@ -206,7 +206,16 @@ The mail requesting the vote should include the following, on a line by itself:<
 <code>
 Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
 </code>
-(NNN is the issue number)</li>
+(NNN is the issue number)<br>
+For example, you can use the following template when requesting the TC vote:<br>
+<code>
+Subject: PATCH [description of changes]<br>
+To: virtio-comment@lists.linux.dev<br>
+
+Could please open a voting ballot for these changes?
+
+Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
+</code></li>
 <li>Please make sure to allow time for review between posting a comment
 and asking for a vote. </li>
 </ol>

base-commit: 124fcd0e97f209aab19639e7369116d99ede22a2
-- 
2.42.0

RE: [PATCH v2] README.md: add example email for TC vote request

[Parav Pandit]

> From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Sent: Thursday, February 27, 2025 8:33 PM
> 
> Acked-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> v1 -> v2: add Subject and To
> ---
>  README.md | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/README.md b/README.md
> index c06caf6..731838b 100644
> --- a/README.md
> +++ b/README.md
> @@ -206,7 +206,16 @@ The mail requesting the vote should include the
> following, on a line by itself:<  <code>
>  Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
>  </code>
> -(NNN is the issue number)</li>
> +(NNN is the issue number)<br>
> +For example, you can use the following template when requesting the TC
> +vote:<br> <code>
> +Subject: PATCH [description of changes]<br>
> +To: virtio-comment@lists.linux.dev<br>
> +
> +Could please open a voting ballot for these changes?
> +
> +Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> +</code></li>
>  <li>Please make sure to allow time for review between posting a comment
> and asking for a vote. </li>  </ol>
> 
> base-commit: 124fcd0e97f209aab19639e7369116d99ede22a2
> --
> 2.42.0
Reviewed-by: Parav Pandit <parav@nvidia.com>

Re: [PATCH v2] README.md: add example email for TC vote request

[Matias Ezequiel Vara Larsen]

On Sat, Mar 01, 2025 at 06:08:32AM +0000, Parav Pandit wrote:
> 
> 
> > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > Sent: Thursday, February 27, 2025 8:33 PM
> > 
> > Acked-by: Cornelia Huck <cohuck@redhat.com>
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > v1 -> v2: add Subject and To
> > ---
> >  README.md | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > diff --git a/README.md b/README.md
> > index c06caf6..731838b 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -206,7 +206,16 @@ The mail requesting the vote should include the
> > following, on a line by itself:<  <code>
> >  Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> >  </code>
> > -(NNN is the issue number)</li>
> > +(NNN is the issue number)<br>
> > +For example, you can use the following template when requesting the TC
> > +vote:<br> <code>
> > +Subject: PATCH [description of changes]<br>
> > +To: virtio-comment@lists.linux.dev<br>
> > +
> > +Could please open a voting ballot for these changes?
> > +
> > +Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> > +</code></li>
> >  <li>Please make sure to allow time for review between posting a comment
> > and asking for a vote. </li>  </ol>
> > 
> > base-commit: 124fcd0e97f209aab19639e7369116d99ede22a2
> > --
> > 2.42.0
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> 

Could please open a voting ballot for these changes?

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/219 

Thanks, Matias.

Re: [PATCH v2] README.md: add example email for TC vote request

[Cornelia Huck]

On Tue, Mar 04 2025, Matias Ezequiel Vara Larsen <mvaralar@redhat.com> wrote:

> On Sat, Mar 01, 2025 at 06:08:32AM +0000, Parav Pandit wrote:
>> 
>> 
>> > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
>> > Sent: Thursday, February 27, 2025 8:33 PM
>> > 
>> > Acked-by: Cornelia Huck <cohuck@redhat.com>
>> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
>> > ---
>> > v1 -> v2: add Subject and To
>> > ---
>> >  README.md | 11 ++++++++++-
>> >  1 file changed, 10 insertions(+), 1 deletion(-)
>> > 
>> > diff --git a/README.md b/README.md
>> > index c06caf6..731838b 100644
>> > --- a/README.md
>> > +++ b/README.md
>> > @@ -206,7 +206,16 @@ The mail requesting the vote should include the
>> > following, on a line by itself:<  <code>
>> >  Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
>> >  </code>
>> > -(NNN is the issue number)</li>
>> > +(NNN is the issue number)<br>
>> > +For example, you can use the following template when requesting the TC
>> > +vote:<br> <code>
>> > +Subject: PATCH [description of changes]<br>
>> > +To: virtio-comment@lists.linux.dev<br>
>> > +
>> > +Could please open a voting ballot for these changes?
>> > +
>> > +Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
>> > +</code></li>
>> >  <li>Please make sure to allow time for review between posting a comment
>> > and asking for a vote. </li>  </ol>
>> > 
>> > base-commit: 124fcd0e97f209aab19639e7369116d99ede22a2
>> > --
>> > 2.42.0
>> Reviewed-by: Parav Pandit <parav@nvidia.com>
>> 
>
> Could please open a voting ballot for these changes?
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/219 
>
> Thanks, Matias.

We can do this via a ballot; I'd also be fine doing this as an editorial
update.

Re: [PATCH v2] README.md: add example email for TC vote request

[Michael S. Tsirkin]

On Mon, Mar 10, 2025 at 02:23:36PM +0100, Cornelia Huck wrote:
> On Tue, Mar 04 2025, Matias Ezequiel Vara Larsen <mvaralar@redhat.com> wrote:
> 
> > On Sat, Mar 01, 2025 at 06:08:32AM +0000, Parav Pandit wrote:
> >> 
> >> 
> >> > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> >> > Sent: Thursday, February 27, 2025 8:33 PM
> >> > 
> >> > Acked-by: Cornelia Huck <cohuck@redhat.com>
> >> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> >> > ---
> >> > v1 -> v2: add Subject and To
> >> > ---
> >> >  README.md | 11 ++++++++++-
> >> >  1 file changed, 10 insertions(+), 1 deletion(-)
> >> > 
> >> > diff --git a/README.md b/README.md
> >> > index c06caf6..731838b 100644
> >> > --- a/README.md
> >> > +++ b/README.md
> >> > @@ -206,7 +206,16 @@ The mail requesting the vote should include the
> >> > following, on a line by itself:<  <code>
> >> >  Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> >> >  </code>
> >> > -(NNN is the issue number)</li>
> >> > +(NNN is the issue number)<br>
> >> > +For example, you can use the following template when requesting the TC
> >> > +vote:<br> <code>
> >> > +Subject: PATCH [description of changes]<br>

No this is wrong. It is

Subject: [PATCH] <description of changes>

or if you want to be more specific:

Subject: [PATCH v<version>] <spec area>:<description of changes>




> >> > +To: virtio-comment@lists.linux.dev<br>
> >> > +
> >> > +Could please open a voting ballot for these changes?
> >> > +
> >> > +Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> >> > +</code></li>
> >> >  <li>Please make sure to allow time for review between posting a comment
> >> > and asking for a vote. </li>  </ol>
> >> > 
> >> > base-commit: 124fcd0e97f209aab19639e7369116d99ede22a2
> >> > --
> >> > 2.42.0
> >> Reviewed-by: Parav Pandit <parav@nvidia.com>
> >> 
> >
> > Could please open a voting ballot for these changes?
> >
> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/219 
> >
> > Thanks, Matias.
> 
> We can do this via a ballot; I'd also be fine doing this as an editorial
> update.

It's not part of the spec - can not be "editorial".
If the change was a change in the bylaws, we'd need a vote.
But it's just a clarification, no need to vote.
Let's get some acks, though.

-- 
MST

Re: [PATCH v2] README.md: add example email for TC vote request

[Matias Ezequiel Vara Larsen]

On Mon, Mar 10, 2025 at 09:55:09AM -0400, Michael S. Tsirkin wrote:
> On Mon, Mar 10, 2025 at 02:23:36PM +0100, Cornelia Huck wrote:
> > On Tue, Mar 04 2025, Matias Ezequiel Vara Larsen <mvaralar@redhat.com> wrote:
> > 
> > > On Sat, Mar 01, 2025 at 06:08:32AM +0000, Parav Pandit wrote:
> > >> 
> > >> 
> > >> > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > >> > Sent: Thursday, February 27, 2025 8:33 PM
> > >> > 
> > >> > Acked-by: Cornelia Huck <cohuck@redhat.com>
> > >> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > >> > ---
> > >> > v1 -> v2: add Subject and To
> > >> > ---
> > >> >  README.md | 11 ++++++++++-
> > >> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > >> > 
> > >> > diff --git a/README.md b/README.md
> > >> > index c06caf6..731838b 100644
> > >> > --- a/README.md
> > >> > +++ b/README.md
> > >> > @@ -206,7 +206,16 @@ The mail requesting the vote should include the
> > >> > following, on a line by itself:<  <code>
> > >> >  Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> > >> >  </code>
> > >> > -(NNN is the issue number)</li>
> > >> > +(NNN is the issue number)<br>
> > >> > +For example, you can use the following template when requesting the TC
> > >> > +vote:<br> <code>
> > >> > +Subject: PATCH [description of changes]<br>
> 
> No this is wrong. It is
> 
> Subject: [PATCH] <description of changes>
> 
> or if you want to be more specific:
> 
> Subject: [PATCH v<version>] <spec area>:<description of changes>
> 
> 

The `<` and `>` characters are not correctly parsed by the markdown
editor. I will replace them with `&lt;` and `&gt;` in v3.

Matias

Re: [PATCH v2] README.md: add example email for TC vote request

[Michael S. Tsirkin]

On Mon, Mar 10, 2025 at 04:58:38PM +0100, Matias Ezequiel Vara Larsen wrote:
> On Mon, Mar 10, 2025 at 09:55:09AM -0400, Michael S. Tsirkin wrote:
> > On Mon, Mar 10, 2025 at 02:23:36PM +0100, Cornelia Huck wrote:
> > > On Tue, Mar 04 2025, Matias Ezequiel Vara Larsen <mvaralar@redhat.com> wrote:
> > > 
> > > > On Sat, Mar 01, 2025 at 06:08:32AM +0000, Parav Pandit wrote:
> > > >> 
> > > >> 
> > > >> > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > >> > Sent: Thursday, February 27, 2025 8:33 PM
> > > >> > 
> > > >> > Acked-by: Cornelia Huck <cohuck@redhat.com>
> > > >> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > >> > ---
> > > >> > v1 -> v2: add Subject and To
> > > >> > ---
> > > >> >  README.md | 11 ++++++++++-
> > > >> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > > >> > 
> > > >> > diff --git a/README.md b/README.md
> > > >> > index c06caf6..731838b 100644
> > > >> > --- a/README.md
> > > >> > +++ b/README.md
> > > >> > @@ -206,7 +206,16 @@ The mail requesting the vote should include the
> > > >> > following, on a line by itself:<  <code>
> > > >> >  Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN
> > > >> >  </code>
> > > >> > -(NNN is the issue number)</li>
> > > >> > +(NNN is the issue number)<br>
> > > >> > +For example, you can use the following template when requesting the TC
> > > >> > +vote:<br> <code>
> > > >> > +Subject: PATCH [description of changes]<br>
> > 
> > No this is wrong. It is
> > 
> > Subject: [PATCH] <description of changes>
> > 
> > or if you want to be more specific:
> > 
> > Subject: [PATCH v<version>] <spec area>:<description of changes>
> > 
> > 
> 
> The `<` and `>` characters are not correctly parsed by the markdown
> editor. I will replace them with `&lt;` and `&gt;` in v3.
> 
> Matias


just use () I think.