Re: [PATCH] git-publish: add profile

[Matias Ezequiel Vara Larsen <mvaralar@redhat.com>]

On Wed, Mar 05, 2025 at 09:21:11AM +0100, Stefano Garzarella wrote:
> On Wed, 5 Mar 2025 at 09:12, Albert Esteve <aesteve@redhat.com> wrote:
> >
> > On Tue, Mar 4, 2025 at 7:47 PM Matias Ezequiel Vara Larsen
> > <mvaralar@redhat.com> wrote:
> > >
> > > Add git-publish profile and document how to use it.
> > >
> > > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > ---
> > >  .gitpublish | 3 +++
> > >  README.md   | 9 +++++++++
> > >  2 files changed, 12 insertions(+)
> > >  create mode 100644 .gitpublish
> > >
> > > diff --git a/.gitpublish b/.gitpublish
> > > new file mode 100644
> > > index 0000000..d412896
> > > --- /dev/null
> > > +++ b/.gitpublish
> > > @@ -0,0 +1,3 @@
> > > +[gitpublishprofile "default"]
> > > +base = master
> > > +to = virtio-comment@lists.linux.dev
> > > diff --git a/README.md b/README.md
> > > index c06caf6..39f22d4 100644
> > > --- a/README.md
> > > +++ b/README.md
> > > @@ -110,6 +110,15 @@ git format-patch -o proposal1/ HEAD~1..<br>
> > >  git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> > >  </code>
> > >
> > > +<dl>Optionally, you can use git-publisher to submit a patch. The procedure is the following:
> >
> 
> I would mention that the project already has a git-publish profile, so
> the "To:" address is automatically handled by it.

Thanks.

> 
> > s/git-publisher/git-publish/ ?
> >
> > Maybe even worth adding a link to the project repository?
> > ```
> > \href{https://github.com/stefanha/git-publish}{git-publish}
> > ```
> 
> +1
> 
> > Especially since you need to install and set up the tool beforehand,
> > so it is nice to have the link pointing to the project documentation.
> >
> > > +<code>
> > > +git checkout master -b my-feature<br>
> > > +# work on new commits, add your 'Signed-off-by' lines to each<br>
> > > +git publish<br>
> >
> > The first run (unless you pre-configure your profile in the project
> > git config) needs to specify the recipient (with --to) and and cc's.
> > I'd add at least the `--to` to the example.
> 
> IIUC the goal of this patch is also to add a profile (.gitpublish) in
> the project exactly to avoid that.

Right, I will clarify that in v2.

Thanks, Matias.