public inbox for virtio-comment@lists.linux.dev
 help / color / mirror / Atom feed
From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: Albert Esteve <aesteve@redhat.com>
Cc: virtio-comment@lists.linux.dev, sgarzare@redhat.com
Subject: Re: [PATCH v2] git-publish: add profile
Date: Wed, 5 Mar 2025 17:13:19 +0100	[thread overview]
Message-ID: <Z8h4H1FYQWK0BFMN@fedora> (raw)
In-Reply-To: <CADSE00LLtG04SHmCp1+DuOsc+E3QqA-BDp=FuhCmAO_uvb_+2g@mail.gmail.com>

On Wed, Mar 05, 2025 at 02:43:05PM +0100, Albert Esteve wrote:
> On Wed, Mar 5, 2025 at 11:58 AM Matias Ezequiel Vara Larsen
> <mvaralar@redhat.com> wrote:
> >
> > Add git-publish profile and document how to use it.
> >
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > v1 -> v2:
> >    * add link to git-publish
> >    * document that the project contain a profile already
> > ---
> >  .gitpublish |  3 +++
> >  README.md   | 13 +++++++++++++
> >  2 files changed, 16 insertions(+)
> >  create mode 100644 .gitpublish
> >
> > diff --git a/.gitpublish b/.gitpublish
> > new file mode 100644
> > index 0000000..d412896
> > --- /dev/null
> > +++ b/.gitpublish
> > @@ -0,0 +1,3 @@
> > +[gitpublishprofile "default"]
> > +base = master
> > +to = virtio-comment@lists.linux.dev
> > diff --git a/README.md b/README.md
> > index c06caf6..3df3fb2 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -110,6 +110,19 @@ git format-patch -o proposal1/ HEAD~1..<br>
> >  git send-email --to=virtio-comment@lists.linux.dev proposal1/0001-*
> >  </code>
> >
> > +<dl>Optionally, you can use
> > +<A
> > +HREF="https://github.com/stefanha/git-publish">git-publish</A> to submit a patch. This project already contains a git-publish's profile that will configure some fields, i.e., To field with the right address. After you have installed git-publish, the procedure is the following:
> 
> Nit: remove uppercase and the line split? Also, you could use acute
> accents surrounding the `To` field, to highlight it in the markdown.
> Also, not sure that the genitive is correct there for `git-publish's
> pofile`. And if you want to give an example, better use `e.g.` instead
> of `i.e.`. So all in all, something like this maybe?
> 
> <a href="https://github.com/stefanha/git-publish">git-publish</a> to
> submit a patch. This project already contains a `git-publish` profile
> that will configure some fields, e.g., `To` field with the right
> address. After you have installed `git-publish`, the procedure is the
> following:
> 

Thanks, I'll send v3 with those changes.

Matias


      reply	other threads:[~2025-03-05 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 10:57 [PATCH v2] git-publish: add profile Matias Ezequiel Vara Larsen
2025-03-05 13:43 ` Albert Esteve
2025-03-05 16:13   ` Matias Ezequiel Vara Larsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8h4H1FYQWK0BFMN@fedora \
    --to=mvaralar@redhat.com \
    --cc=aesteve@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=virtio-comment@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox