From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: virtio-comment@lists.linux.dev
Cc: anton.yakovlev@opensynergy.com, mvaralar@redhat.com
Subject: [PATCH Resend] virtio-snd: improve PCM command lifecycle description
Date: Tue, 21 May 2024 17:13:18 +0200 [thread overview]
Message-ID: <Zky6Disx1ofmETmn@fedora> (raw)
The PCM command lifecycle can be described as a state-machine in which
the switching between states is triggered by commands. This commit
explicitly presents the different states and the commands that are
allowed in a given state. This commit leaves to the implementation the
decision the state reached depending on the command.
Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
---
device-types/sound/description.tex | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/device-types/sound/description.tex b/device-types/sound/description.tex
index 54c9c8e..55e93af 100644
--- a/device-types/sound/description.tex
+++ b/device-types/sound/description.tex
@@ -397,9 +397,21 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
\item[\field{stream_id}] specifies a PCM stream identifier from 0 to \field{streams} - 1.
\end{description}
-\paragraph{PCM Command Lifecycle}
+\paragraph{PCM Command Lifecycle State Machine}
-A PCM stream has the following command lifecycle:
+A PCM stream can be represented by a state-machine made up of the following
+states:
+\begin{description}
+\item SET PARAMETERS
+\item PREPARE
+\item START
+\item STOP
+\item RELEASE
+\end{description}
+
+A command triggers the transition between these states. To what state to switch
+depends on the implementation. Depending on the state, only certain commands
+are valid. An error may occur if an invalid command is triggered.
\begin{enumerate}
\item SET PARAMETERS
@@ -407,13 +419,13 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
The driver negotiates the stream parameters (format, transport, etc) with
the device.
-Possible valid transitions: set parameters, prepare.
+Possible valid commands: set parameters, prepare.
\item PREPARE
The device prepares the stream (allocates resources, etc).
-Possible valid transitions: set parameters, prepare, start, release.
+Possible valid commands: set parameters, prepare, start, release.
\item Output only: the driver transfers data for pre-buffing.
@@ -421,7 +433,7 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
The device starts the stream (unmute, putting into running state, etc).
-Possible valid transitions: stop.
+Possible valid commands: stop.
\item The driver transfers data to/from the stream.
@@ -429,13 +441,13 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
The device stops the stream (mute, putting into non-running state, etc).
-Possible valid transitions: start, release.
+Possible valid commands: start, release.
\item RELEASE
The device releases the stream (frees resources, etc).
-Possible valid transitions: set parameters, prepare.
+Possible valid commands: set parameters, prepare.
\end{enumerate}
--
2.41.0
next reply other threads:[~2024-05-21 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 15:13 Matias Ezequiel Vara Larsen [this message]
2024-05-23 11:00 ` [PATCH Resend] virtio-snd: improve PCM command lifecycle description Stefano Garzarella
2024-05-27 13:40 ` Matias Ezequiel Vara Larsen
2024-05-28 15:12 ` Stefano Garzarella
2024-05-29 6:42 ` Manos Pitsidianakis
2024-06-06 11:09 ` Matias Ezequiel Vara Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zky6Disx1ofmETmn@fedora \
--to=mvaralar@redhat.com \
--cc=anton.yakovlev@opensynergy.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox