Re: [PATCH] virtio-can: rephrase notification mechanism

[Matias Ezequiel Vara Larsen <mvaralar@redhat.com>]

On Wed, Jun 05, 2024 at 07:55:05PM +0200, Harald Mommer wrote:
> Hello,
> 
> exactly this is my problem here also. For me this change looks like saying
> exactly the same thing just in different (not better) words.
> 
> Thinking still about the replacement "from the driver" => "by the driver".
> Was the original "from the driver" correct? My native language is German and
> of course it can be that I made a grammar mistake applying German grammar to
> an English text. Absolutely unclear to me.
> 
> But if it's not that I have as a non-native speaker of English in the moment
> no idea where the improvement is.
> 
> Regards
> Harald
> 
> On 05.06.24 10:46, Stefano Garzarella wrote:
> > On Tue, May 21, 2024 at 04:12:45PM GMT, Matias Ezequiel Vara Larsen
> > wrote:
> > > Rephrase the notification mechanism.
> > 
> > I'd suggest to explain here what are we clarifying with the rephrase.
> > Sorry, I'm not a CAN expert, so I don't understand the difference
> > between the two versions.
> > 

Thanks both for the review. The only sentence that I wanted to change
is:

"As the configuration \field{status} change is caused by a request from
the driver the device is allowed to omit the configuration change
notification here."

I though it could be rewritten in a more direct way like:

"The device may omit the configuration change notification as the
configuration \field{status} change is requested by the driver. "

But I don't know if that clarifies anything. If not, we can drop this
patch.

Matias