[PATCH v1] virtio-can: rephrase notification mechanism

[PATCH v1] virtio-can: rephrase notification mechanism

[Matias Ezequiel Vara Larsen]

Rephrase when the device may omit to notify the driver due to a status
change in a more straight-forward way.

Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
---
* This patch applies on top of virtio-1.4, which has not been released
  yet.

v0 -> v1:
    * Rephrase commit message
---
 device-types/can/description.tex | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/device-types/can/description.tex b/device-types/can/description.tex
index 2511d9c..b13da9c 100644
--- a/device-types/can/description.tex
+++ b/device-types/can/description.tex
@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
 \end{lstlisting}
 
 If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
+device updates the configuration \field{status} before marking the request
+used. The device may omit the configuration change notification when the
+configuration \field{status} change is requested by the driver. The device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.
 
 On transition to the STOPPED state the device cancels all CAN messages
 already pending for transmission and marks them as used with

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2
-- 
2.42.0

Re: [PATCH v1] virtio-can: rephrase notification mechanism

[Stefano Garzarella]

On Thu, Jun 13, 2024 at 05:59:26PM GMT, Matias Ezequiel Vara Larsen wrote:
>Rephrase when the device may omit to notify the driver due to a status
>change in a more straight-forward way.
>
>Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
>---
>* This patch applies on top of virtio-1.4, which has not been released
>  yet.
>
>v0 -> v1:
>    * Rephrase commit message
>---
> device-types/can/description.tex | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)

LGTM:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/device-types/can/description.tex b/device-types/can/description.tex
>index 2511d9c..b13da9c 100644
>--- a/device-types/can/description.tex
>+++ b/device-types/can/description.tex
>@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
> \end{lstlisting}
>
> If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK
>-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
>-necessary, the device updates the configuration \field{status} before
>-marking the request used. As the configuration \field{status} change is
>-caused by a request from the driver the device is allowed to omit the
>-configuration change notification here. The device marks the request
>-used when the CAN controller has finalized the transition to the
>-requested controller mode.
>+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
>+device updates the configuration \field{status} before marking the request
>+used. The device may omit the configuration change notification when the
>+configuration \field{status} change is requested by the driver. The device
>+marks the request used when the CAN controller has finalized the transition to
>+the requested controller mode.
>
> On transition to the STOPPED state the device cancels all CAN messages
> already pending for transmission and marks them as used with
>
>base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2
>-- 
>2.42.0
>

Re: [PATCH v1] virtio-can: rephrase notification mechanism

[Matias Ezequiel Vara Larsen]

On Thu, Jun 13, 2024 at 05:59:26PM +0200, Matias Ezequiel Vara Larsen wrote:
> Rephrase when the device may omit to notify the driver due to a status
> change in a more straight-forward way.
> 
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> * This patch applies on top of virtio-1.4, which has not been released
>   yet.
> 
> v0 -> v1:
>     * Rephrase commit message
> ---
>  device-types/can/description.tex | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/device-types/can/description.tex b/device-types/can/description.tex
> index 2511d9c..b13da9c 100644
> --- a/device-types/can/description.tex
> +++ b/device-types/can/description.tex
> @@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
>  \end{lstlisting}
>  
>  If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK
> -otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
> -necessary, the device updates the configuration \field{status} before
> -marking the request used. As the configuration \field{status} change is
> -caused by a request from the driver the device is allowed to omit the
> -configuration change notification here. The device marks the request
> -used when the CAN controller has finalized the transition to the
> -requested controller mode.
> +otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
> +device updates the configuration \field{status} before marking the request
> +used. The device may omit the configuration change notification when the
> +configuration \field{status} change is requested by the driver. The device
> +marks the request used when the CAN controller has finalized the transition to
> +the requested controller mode.
>  
>  On transition to the STOPPED state the device cancels all CAN messages
>  already pending for transmission and marks them as used with
> 
> base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2
> -- 
> 2.42.0
> 
Dear TC,

I'd like to request a vote on solving issue 199.

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/199