From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: virtio-comment@lists.linux.dev
Cc: anton.yakovlev@opensynergy.com, sgarzare@redhat.com
Subject: Re: [PATCH v1 Resend] virtio-sound: add latency_bytes definition
Date: Fri, 21 Jun 2024 15:37:29 +0200 [thread overview]
Message-ID: <ZnWCGR9tkSrKPzX2@fedora> (raw)
In-Reply-To: <Zky3vZU+P37H4VPb@fedora>
On Tue, May 21, 2024 at 05:03:25PM +0200, Matias Ezequiel Vara Larsen wrote:
> This commit aims at providing a better definition of latency_bytes. To
> do so, this commit defines latency_bytes as is defined in Crosvm.
>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> Changelog:
> v0 -> v1:
> * specify that the delay is due to the device implementation.
> ---
> device-types/sound/description.tex | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/sound/description.tex b/device-types/sound/description.tex
> index 54c9c8e..a138e5b 100644
> --- a/device-types/sound/description.tex
> +++ b/device-types/sound/description.tex
> @@ -694,7 +694,10 @@ \subsubsection{PCM I/O Messages}\label{sec:Device Types / Sound Device / Device
> \begin{description}
> \item[\field{status}] contains VIRTIO_SND_S_OK if an operation is successful,
> and VIRTIO_SND_S_IO_ERR otherwise.
> -\item[\field{latency_bytes}] indicates the current device latency.
> +\item[\field{latency_bytes}] indicates the current additional delay caused by
> +the device's implementation. For playback, this is the amount of bytes that
> +must be consumed before the current request can be played. For capture, this is
> +the latency in terms of bytes that the capture buffer was recorded.
> \end{description}
>
> Since all buffers in the queue (with one exception) should be of the size
> --
> 2.41.0
>
Dear TC,
I'd like to request a vote on solving issue 198.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/198
Matias
next prev parent reply other threads:[~2024-06-21 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 15:03 [PATCH v1 Resend] virtio-sound: add latency_bytes definition Matias Ezequiel Vara Larsen
2024-05-23 10:52 ` Stefano Garzarella
2024-06-21 13:37 ` Matias Ezequiel Vara Larsen [this message]
2024-06-21 13:56 ` Michael S. Tsirkin
2024-06-25 10:43 ` Matias Ezequiel Vara Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnWCGR9tkSrKPzX2@fedora \
--to=mvaralar@redhat.com \
--cc=anton.yakovlev@opensynergy.com \
--cc=sgarzare@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox