RE: [PATCH 2/3] gpu: editorial: Fix spelling errors

Parav Pandit
2024-09-10T16:42:23Z

> From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Sent: Monday, September 9, 2024 7:42 PM
>
> On Sat, Sep 07, 2024 at 08:48:18PM +0300, Parav Pandit wrote:
> > Fix spelling errors.
> >
> > Branch: virtio-1.4
> > Fixes: fed64230bf31 ("Add virtio gpu device specification.")
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> > device-types/gpu/description.tex | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/device-types/gpu/description.tex
> > b/device-types/gpu/description.tex
> > index 66e4873..ba4ea76 100644
> > --- a/device-types/gpu/description.tex
> > +++ b/device-types/gpu/description.tex
> > @@ -166,7 +166,7 @@ \subsubsection{Device Operation: Multihead setup}
> >
> > \devicenormative{\subsubsection}{Device Operation: Command lifecycle
> > and fencing}{Device Types / GPU Device / Device Operation / Device
> > Operation: Command lifecycle and fencing}
> >
> > -The device MAY process controlq commands asyncronously and return
> > them
> > +The device MAY process controlq commands asynchronously and return
> > +them
> > to the driver before the processing is complete. If the driver needs
>
> I think here is `completed` instead of `complete` although it is not part of
> this patch.
>
> > to know when the processing is finished it can set the
> > VIRTIO_GPU_FLAG_FENCE flag in the request. The device MUST finish the
> > @@ -345,7 +345,7 @@ \subsubsection{Device Operation:
> > controlq}\label{sec:Device Types / GPU Device / display).
> >
> > The \field{enabled} field is set when the user enabled the display.
>
> I am not sure if it is `enables` instead of `enabled`.
>
You are right for both the comments.
Will send separate patch to fix them.

Thank you for the review of the series.

> > -It is roughly the same as the connected state of a phyiscal display
> > +It is roughly the same as the connected state of a physical display
> > connector.
> >
> > \item[VIRTIO_GPU_CMD_GET_EDID] Retrieve the EDID data for a given
> > --
> > 2.34.1
> >
> >
>
> Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
>
> Thanks, Matias.