From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-comment@lists.linux.dev, mst@redhat.com,
cohuck@redhat.com, shahafs@nvidia.com
Subject: Re: [PATCH] device-parts: editorial: Fix metadata type name
Date: Mon, 9 Sep 2024 16:18:18 +0200 [thread overview]
Message-ID: <Zt8DqrYIXGMM399j@fedora> (raw)
In-Reply-To: <20240907165218.778501-1-parav@nvidia.com>
On Sat, Sep 07, 2024 at 07:52:18PM +0300, Parav Pandit wrote:
> The description is for the type VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_LIST;
> however, it referred to a non-existent definition. Correct it.
>
> Branch: virtio-1.4
> Fixes: aa4f6f069ab3 ("admin: Add admin commands for device parts")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> admin-cmds-device-parts.tex | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/admin-cmds-device-parts.tex b/admin-cmds-device-parts.tex
> index 27d8251..3a16692 100644
> --- a/admin-cmds-device-parts.tex
> +++ b/admin-cmds-device-parts.tex
> @@ -152,10 +152,10 @@ \subsubsection{Device parts}\label{sec:Basic Facilities of a Virtio Device / Dev
> device responds with \field{hdr_list_count.count}. The
> \field{hdr_list_count.count} indicates an count of
> \field{struct virtio_dev_part_hdr} metadata entries that the device can
> -provide when the \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_HDR
> +provide when the \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_LIST
> in a subsequent VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_GET command.
>
> -When \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_HDR,
> +When \field{type} is set to VIRTIO_ADMIN_CMD_DEV_PARTS_METADATA_TYPE_LIST,
> the device responds with \field{hdr_list}. \field{hdr_list}
> indicates the device parts metadata.
>
> --
> 2.34.1
>
>
In previous patches, I see the pattern `\field{type} field`. I wonder if
you would like to do the same here for consistency but I do not have a
strong opinion about this. Otherwise,
Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Thanks, Matias.
next prev parent reply other threads:[~2024-09-09 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 16:52 [PATCH] device-parts: editorial: Fix metadata type name Parav Pandit
2024-09-09 14:18 ` Matias Ezequiel Vara Larsen [this message]
2024-09-10 16:46 ` Parav Pandit
2024-09-10 16:48 ` Michael S. Tsirkin
2024-09-10 16:51 ` Parav Pandit
2024-09-10 18:34 ` Michael S. Tsirkin
2024-09-10 18:54 ` Parav Pandit
2024-09-10 20:21 ` Michael S. Tsirkin
2024-09-11 3:19 ` Parav Pandit
2024-09-11 10:01 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt8DqrYIXGMM399j@fedora \
--to=mvaralar@redhat.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox