From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-comment@lists.linux.dev, mst@redhat.com,
cohuck@redhat.com, shahafs@nvidia.com
Subject: Re: [PATCH 2/3] device-parts: Add device type specific raw selector
Date: Fri, 18 Oct 2024 18:13:08 +0200 [thread overview]
Message-ID: <ZxKJFLT5Ewn5Qhf/@fedora> (raw)
In-Reply-To: <20241018131741.443635-3-parav@nvidia.com>
On Fri, Oct 18, 2024 at 04:17:40PM +0300, Parav Pandit wrote:
> The subsequent patch defines the device-type-specific parts. For
> these parts, the raw selector format is defined to ensure that
> each device type can specify its format accurately.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/209
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> device-parts.tex | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/device-parts.tex b/device-parts.tex
> index e59c0f9..ee743c2 100644
> --- a/device-parts.tex
> +++ b/device-parts.tex
> @@ -21,6 +21,7 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
> le16 index;
> u8 reserved[6];
> } vq_index;
> + u8 device_type_raw[8];
> } selector;
> le32 length;
> };
> @@ -77,6 +78,9 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
> only when the \field{part_type} is VIRTIO_DEV_PART_VQ_CFG or
> VIRTIO_DEV_PART_VQ_NOTIFY_CFG.
>
> +\field{selector.device_type_raw} is only used when a device-specific part is
> +utilized, with \field{part_type} ranging from 0x0200 to 0x05FF.
Why is important here to mention the range of `part_type`?
Matias
next prev parent reply other threads:[~2024-10-18 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 13:17 [PATCH 0/3] virtio-net: Define cvq configuration related device parts Parav Pandit
2024-10-18 13:17 ` [PATCH 1/3] device-parts: editorial: Replace duplicated part type Parav Pandit
2024-10-18 15:57 ` Matias Ezequiel Vara Larsen
2024-10-18 13:17 ` [PATCH 2/3] device-parts: Add device type specific raw selector Parav Pandit
2024-10-18 16:13 ` Matias Ezequiel Vara Larsen [this message]
2024-10-18 16:52 ` Parav Pandit
2024-10-21 17:58 ` Matias Ezequiel Vara Larsen
2024-10-18 13:17 ` [PATCH 3/3] virtio-net: Define cvq configuration related device parts Parav Pandit
2024-10-18 16:24 ` Matias Ezequiel Vara Larsen
2024-10-18 16:54 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxKJFLT5Ewn5Qhf/@fedora \
--to=mvaralar@redhat.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox