Re: [PATCH v1 2/3] device-parts: Add device type specific raw selector

Matias Ezequiel Vara Larsen
2024-10-21T18:12:57Z

On Sun, Oct 20, 2024 at 02:41:40PM +0300, Parav Pandit wrote:
> The subsequent patch defines the device-type-specific parts. For
> these parts, the raw selector format is defined to ensure that
> each device type can specify its format accurately.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/209
> Signed-off-by: Parav Pandit <parav@nvidia.com>
>
> ---
> changelog:
> v0->v1:
> - addressed comment from Matias
> - rewrote description of selector without writing the actual
> part_type range, add description that it is device type specific
> ---
> device-parts.tex | 5 +++++
> 1 file changed, 5 insertions(+)

Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>

>
> diff --git a/device-parts.tex b/device-parts.tex
> index e59c0f9..1d6be87 100644
> --- a/device-parts.tex
> +++ b/device-parts.tex
> @@ -21,6 +21,7 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
> le16 index;
> u8 reserved[6];
> } vq_index;
> + u8 device_type_raw[8];
> } selector;
> le32 length;
> };
> @@ -77,6 +78,10 @@ \section{Device parts}\label{sec:Basic Facilities of a Virtio Device / Device pa
> only when the \field{part_type} is VIRTIO_DEV_PART_VQ_CFG or
> VIRTIO_DEV_PART_VQ_NOTIFY_CFG.
>
> +\field{selector.device_type_raw} is applicable only when the \field{part_type}
> +corresponds to a device-specific range. The format of
> +\field{selector.device_type_raw} is device type specific.
> +
> \subsection{Common device parts}\label{sec:Basic Facilities of a Virtio Device / Device parts / Common device parts}
>
> Common parts are independent of the device type.
> --
> 2.34.1
>