RE: [PATCH v1 0/3] virtio-net: Define cvq configuration related device parts

Parav Pandit
2024-11-03T05:15:40Z

Hi Matias, Michael,

> From: Parav Pandit <parav@nvidia.com>
> Sent: Sunday, October 20, 2024 5:12 PM
> To: virtio-comment@lists.linux.dev; mst@redhat.com; cohuck@redhat.com;
> mvaralar@redhat.com
> Cc: Shahaf Shuler <shahafs@nvidia.com>; Parav Pandit <parav@nvidia.com>
> Subject: [PATCH v1 0/3] virtio-net: Define cvq configuration related device
> parts
>
> virtio net driver sends the control virtqueue commands for device
> configuration. Such driver configuration is currently not captured in the
> device parts.
>
> This series adds several of such device parts which represents the network
> device specific configuration.
>
> It is done by utilizing the existing device parts structure.
> A new generic selector format is added to enable device type specific device
> parts.
>
> This series also reuses the existing control virtqueue command structures,
> fields, and values to define the network device parts.
>
> Patch summary:
> patch-1 fixes a duplicate part name
> patch-2 adds device type specific raw selector
> patch-3 defines several cvq command related device parts
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/209
>
> ---
> changelog:
> v0->v1:
> - fixed comments from Matias
> - fixed spelling of selectors
> - rewrote description of selector without writing the actual
> part_type range along with description that it is device type
> specific
>

These short fixes and improvements are reviewed now.
Can you please raise for the vote?

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/209

> Parav Pandit (3):
> device-parts: editorial: Replace duplicated part type
> device-parts: Add device type specific raw selector
> virtio-net: Define cvq configuration related device parts
>
> device-parts.tex | 7 ++-
> device-types/net/description.tex | 90
> ++++++++++++++++++++++++++++++++
> 2 files changed, 96 insertions(+), 1 deletion(-)
>
> --
> 2.34.1