[PATCH] virtio-gpu: Fix missing driver conformance file

[PATCH] virtio-gpu: Fix missing driver conformance file

[Parav Pandit]

Cited patch in the fixes tag missed to include the driver-conformance
file. Add it.

Fixes: f52fb20cbe38 ("virtio-gpu: support blob alignment information")
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
 device-types/gpu/driver-conformance.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 device-types/gpu/driver-conformance.tex

diff --git a/device-types/gpu/driver-conformance.tex b/device-types/gpu/driver-conformance.tex
new file mode 100644
index 0000000..9ef708e
--- /dev/null
+++ b/device-types/gpu/driver-conformance.tex
@@ -0,0 +1,8 @@
+\conformance{\subsection}{GPU Driver Conformance}\label{sec:Conformance / Driver Conformance / GPU Driver Conformance}
+
+A GPU Driver MUST conform to the following normative statements:
+
+\begin{itemize}
+\item \ref{drivernormative:Device Types / GPU Device / Device Operation / Device Operation: controlq}
+\item \ref{drivernormative:Device Types / GPU Device / Device Operation / Device Operation: controlq (3d)}
+\end{itemize}
-- 
2.34.1

Re: [PATCH] virtio-gpu: Fix missing driver conformance file

[Matias Ezequiel Vara Larsen]

On Sat, Jun 14, 2025 at 09:13:02PM +0300, Parav Pandit wrote:
> Cited patch in the fixes tag missed to include the driver-conformance
> file. Add it.
> 
> Fixes: f52fb20cbe38 ("virtio-gpu: support blob alignment information")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
>  device-types/gpu/driver-conformance.tex | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 device-types/gpu/driver-conformance.tex
> 

Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>

RE: [PATCH] virtio-gpu: Fix missing driver conformance file

[Parav Pandit]

Hi ,

> From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Sent: 16 June 2025 04:00 PM
> 
> On Sat, Jun 14, 2025 at 09:13:02PM +0300, Parav Pandit wrote:
> > Cited patch in the fixes tag missed to include the driver-conformance
> > file. Add it.
> >
> > Fixes: f52fb20cbe38 ("virtio-gpu: support blob alignment information")
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > ---
> >  device-types/gpu/driver-conformance.tex | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >  create mode 100644 device-types/gpu/driver-conformance.tex
> >
> 
> Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>

Can you please raise the voting ballot for this patch which fixes https://github.com/oasis-tcs/virtio-spec/issues/223?
I didn't create a new github issue as 223 is open and its half written patches are not merged.
It is fixed with this patch.

Re: [PATCH] virtio-gpu: Fix missing driver conformance file

[Matias Ezequiel Vara Larsen]

On Tue, Jul 08, 2025 at 06:56:26AM +0000, Parav Pandit wrote:
> Hi ,
> 
> > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > Sent: 16 June 2025 04:00 PM
> > 
> > On Sat, Jun 14, 2025 at 09:13:02PM +0300, Parav Pandit wrote:
> > > Cited patch in the fixes tag missed to include the driver-conformance
> > > file. Add it.
> > >
> > > Fixes: f52fb20cbe38 ("virtio-gpu: support blob alignment information")
> > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > > ---
> > >  device-types/gpu/driver-conformance.tex | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >  create mode 100644 device-types/gpu/driver-conformance.tex
> > >
> > 
> > Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> 
> Can you please raise the voting ballot for this patch which fixes https://github.com/oasis-tcs/virtio-spec/issues/223?
> I didn't create a new github issue as 223 is open and its half written patches are not merged.
> It is fixed with this patch.
> 

Why is it still open if the ballot has been voted?

Thanks, Matias

RE: [PATCH] virtio-gpu: Fix missing driver conformance file

[Parav Pandit]

> From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Sent: 08 July 2025 01:36 PM
> 
> On Tue, Jul 08, 2025 at 06:56:26AM +0000, Parav Pandit wrote:
> > Hi ,
> >
> > > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > Sent: 16 June 2025 04:00 PM
> > >
> > > On Sat, Jun 14, 2025 at 09:13:02PM +0300, Parav Pandit wrote:
> > > > Cited patch in the fixes tag missed to include the
> > > > driver-conformance file. Add it.
> > > >
> > > > Fixes: f52fb20cbe38 ("virtio-gpu: support blob alignment
> > > > information")
> > > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > > > ---
> > > >  device-types/gpu/driver-conformance.tex | 8 ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > >  create mode 100644 device-types/gpu/driver-conformance.tex
> > > >
> > >
> > > Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> >
> > Can you please raise the voting ballot for this patch which fixes
> https://github.com/oasis-tcs/virtio-spec/issues/223?
> > I didn't create a new github issue as 223 is open and its half written patches
> are not merged.
> > It is fixed with this patch.
> >
> 
> Why is it still open if the ballot has been voted?
> 
> Thanks, Matias

I dint merge because basic makepdf etc scripts fail without this proposed fix.
And this proposed fix is non editorial in my view.
So this proposed patch needs vote. Once voting passes, I will merge the original patch + this fix for the same issue 223.

Re: [PATCH] virtio-gpu: Fix missing driver conformance file

[Matias Ezequiel Vara Larsen]

On Tue, Jul 08, 2025 at 08:11:43AM +0000, Parav Pandit wrote:
> 
> 
> > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > Sent: 08 July 2025 01:36 PM
> > 
> > On Tue, Jul 08, 2025 at 06:56:26AM +0000, Parav Pandit wrote:
> > > Hi ,
> > >
> > > > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > > Sent: 16 June 2025 04:00 PM
> > > >
> > > > On Sat, Jun 14, 2025 at 09:13:02PM +0300, Parav Pandit wrote:
> > > > > Cited patch in the fixes tag missed to include the
> > > > > driver-conformance file. Add it.
> > > > >
> > > > > Fixes: f52fb20cbe38 ("virtio-gpu: support blob alignment
> > > > > information")
> > > > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > > > > ---
> > > > >  device-types/gpu/driver-conformance.tex | 8 ++++++++
> > > > >  1 file changed, 8 insertions(+)
> > > > >  create mode 100644 device-types/gpu/driver-conformance.tex
> > > > >
> > > >
> > > > Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > >
> > > Can you please raise the voting ballot for this patch which fixes
> > https://github.com/oasis-tcs/virtio-spec/issues/223?
> > > I didn't create a new github issue as 223 is open and its half written patches
> > are not merged.
> > > It is fixed with this patch.
> > >
> > 
> > Why is it still open if the ballot has been voted?
> > 
> > Thanks, Matias
> 
> I dint merge because basic makepdf etc scripts fail without this proposed fix.
> And this proposed fix is non editorial in my view.
> So this proposed patch needs vote. Once voting passes, I will merge the original patch + this fix for the same issue 223.
> 

I see, since it looks like a non editorial change, should we open a
ballot for that? Can't we just merge it?

Matias

RE: [PATCH] virtio-gpu: Fix missing driver conformance file

[Parav Pandit]

> From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> Sent: 08 July 2025 01:58 PM
> On Tue, Jul 08, 2025 at 08:11:43AM +0000, Parav Pandit wrote:
> >
> >
> > > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > Sent: 08 July 2025 01:36 PM
> > >
> > > On Tue, Jul 08, 2025 at 06:56:26AM +0000, Parav Pandit wrote:
> > > > Hi ,
> > > >
> > > > > From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > > > Sent: 16 June 2025 04:00 PM
> > > > >
> > > > > On Sat, Jun 14, 2025 at 09:13:02PM +0300, Parav Pandit wrote:
> > > > > > Cited patch in the fixes tag missed to include the
> > > > > > driver-conformance file. Add it.
> > > > > >
> > > > > > Fixes: f52fb20cbe38 ("virtio-gpu: support blob alignment
> > > > > > information")
> > > > > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > > > > > ---
> > > > > >  device-types/gpu/driver-conformance.tex | 8 ++++++++
> > > > > >  1 file changed, 8 insertions(+)  create mode 100644
> > > > > > device-types/gpu/driver-conformance.tex
> > > > > >
> > > > >
> > > > > Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > > >
> > > > Can you please raise the voting ballot for this patch which fixes
> > > https://github.com/oasis-tcs/virtio-spec/issues/223?
> > > > I didn't create a new github issue as 223 is open and its half
> > > > written patches
> > > are not merged.
> > > > It is fixed with this patch.
> > > >
> > >
> > > Why is it still open if the ballot has been voted?
> > >
> > > Thanks, Matias
> >
> > I dint merge because basic makepdf etc scripts fail without this proposed fix.
> > And this proposed fix is non editorial in my view.
> > So this proposed patch needs vote. Once voting passes, I will merge the
> original patch + this fix for the same issue 223.
> >
> 
> I see, since it looks like a non editorial change, should we open a ballot for that?
> Can't we just merge it?
> 
Previously general guidance was, if in doubt ask for vote. 😊
So, I will let Michael and Cornelia to guide for this one.