public inbox for virtio-comment@lists.linux.dev
 help / color / mirror / Atom feed
From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: Zhu Lingshan <lingshan.zhu@amd.com>
Cc: mst@redhat.com, cohuck@redhat.com, jasowang@redhat.com,
	virtio-comment@lists.linux.dev, Ray.Huang@amd.com,
	Parav Pandit <parav@nvidia.com>
Subject: Re: [PATCH v4 1/3] virtio: re-order device status bits
Date: Thu, 3 Jul 2025 10:01:46 +0200	[thread overview]
Message-ID: <aGY46ohk966g/EIQ@fedora> (raw)
In-Reply-To: <20250702085421.342224-2-lingshan.zhu@amd.com>

On Wed, Jul 02, 2025 at 04:54:19PM +0800, Zhu Lingshan wrote:
> This commit re-arranges the device status bits,
> to list them in ascending order.
> 
> Signed-off-by: Zhu Lingshan <lingshan.zhu@amd.com>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/229
> ---
>  content.tex | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 

Reviewed-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>

> diff --git a/content.tex b/content.tex
> index d3fc6a4..1efc2a5 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -36,19 +36,19 @@ \section{\field{Device Status} Field}\label{sec:Basic Facilities of a Virtio Dev
>      this bit.  For example, under Linux, drivers can be loadable modules.
>    \end{note}
>  
> -\item[FAILED (128)] Indicates that something went wrong in the guest,
> -  and it has given up on the device. This could be an internal
> -  error, or the driver didn't like the device for some reason, or
> -  even a fatal error during device operation.
> +\item[DRIVER_OK (4)] Indicates that the driver is set up and ready to
> +  drive the device.
>  
>  \item[FEATURES_OK (8)] Indicates that the driver has acknowledged all the
>    features it understands, and feature negotiation is complete.
>  
> -\item[DRIVER_OK (4)] Indicates that the driver is set up and ready to
> -  drive the device.
> -
>  \item[DEVICE_NEEDS_RESET (64)] Indicates that the device has experienced
>    an error from which it can't recover.
> +
> +\item[FAILED (128)] Indicates that something went wrong in the guest,
> +  and it has given up on the device. This could be an internal
> +  error, or the driver didn't like the device for some reason, or
> +  even a fatal error during device operation.
>  \end{description}
>  
>  The \field{device status} field starts out as 0, and is reinitialized to 0 by
> -- 
> 2.49.0
> 
> 


  reply	other threads:[~2025-07-03  8:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02  8:54 [PATCH v4 0/3] Implement virtio SUSPEND and RESUME feature Zhu Lingshan
2025-07-02  8:54 ` [PATCH v4 1/3] virtio: re-order device status bits Zhu Lingshan
2025-07-03  8:01   ` Matias Ezequiel Vara Larsen [this message]
2025-07-02  8:54 ` [PATCH v4 2/3] virtio: document feature bit 42 Zhu Lingshan
2025-07-02 11:27   ` Parav Pandit
2025-07-02  8:54 ` [PATCH v4 3/3] virtio: introduce SUSPEND and RESUME feature Zhu Lingshan
2025-07-02 11:53   ` Parav Pandit
2025-07-04  9:54     ` Zhu, Lingshan
2025-07-04  9:58       ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGY46ohk966g/EIQ@fedora \
    --to=mvaralar@redhat.com \
    --cc=Ray.Huang@amd.com \
    --cc=cohuck@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lingshan.zhu@amd.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox