Discussion of the VIRTIO specification
 help / color / mirror / Atom feed
From: "Zhu, Lingshan" <lingshan.zhu@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, eperezma@redhat.com, cohuck@redhat.com,
	stefanha@redhat.com, virtio-comment@lists.oasis-open.org,
	virtio-dev@lists.oasis-open.org
Subject: Re: [virtio-comment] [PATCH 0/5] virtio: introduce SUSPEND bit and vq state
Date: Wed, 6 Sep 2023 16:38:44 +0800	[thread overview]
Message-ID: <aa6101cc-caf6-95e9-89cd-614ac7a43e55@intel.com> (raw)
In-Reply-To: <20230906042851-mutt-send-email-mst@kernel.org>



On 9/6/2023 4:29 PM, Michael S. Tsirkin wrote:
> On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote:
>> This series introduces
>> 1)a new SUSPEND bit in the device status
>> Which is used to suspend the device, so that the device states
>> and virtqueue states are stabilized.
>>
>> 2)virtqueue state and its accessor, to get and set last_avail_idx
>> and last_used_idx of virtqueues.
>>
>> The main usecase of these new facilities is Live Migration.
>>
>> Future work: dirty page tracking and in-flight descriptors.
> oh that answers my question - it's not covered.
> I don't think we can merge this without in-flight descriptor
> support.
When SUSPEND, we require the device wait until all descriptors that
being processed to finish and mark them as used.(In patch 2)

at this point there may be no in-flight descriptors, so this is still
self-consistent. The tracker for in-flight descriptors is excluded to
make this series small and focus.
>
>
>
>> This series addresses many comments from Jason, Stefan and Eugenio
>> from RFC series.
>>
>> Zhu Lingshan (5):
>>    virtio: introduce vq state as basic facility
>>    virtio: introduce SUSPEND bit in device status
>>    virtqueue: constraints for virtqueue state
>>    virtqueue: ignore resetting vqs when SUSPEND
>>    virtio-pci: implement VIRTIO_F_QUEUE_STATE
>>
>>   content.tex       | 118 ++++++++++++++++++++++++++++++++++++++++++++++
>>   transport-pci.tex |  18 +++++++
>>   2 files changed, 136 insertions(+)
>>
>> -- 
>> 2.35.3
>>
>>
>> This publicly archived list offers a means to provide input to the
>> OASIS Virtual I/O Device (VIRTIO) TC.
>>
>> In order to verify user consent to the Feedback License terms and
>> to minimize spam in the list archive, subscription is required
>> before posting.
>>
>> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
>> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
>> List help: virtio-comment-help@lists.oasis-open.org
>> List archive: https://lists.oasis-open.org/archives/virtio-comment/
>> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
>> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
>> Committee: https://www.oasis-open.org/committees/virtio/
>> Join OASIS: https://www.oasis-open.org/join/
>>


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  reply	other threads:[~2023-09-06  8:39 UTC|newest]

Thread overview: 148+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06  8:16 [virtio-comment] [PATCH 0/5] virtio: introduce SUSPEND bit and vq state Zhu Lingshan
2023-09-06  8:16 ` [virtio-comment] [PATCH 1/5] virtio: introduce vq state as basic facility Zhu Lingshan
2023-09-06  8:28   ` Michael S. Tsirkin
2023-09-06  9:43     ` Zhu, Lingshan
2023-09-14 11:25   ` Michael S. Tsirkin
2023-09-15  2:46     ` Zhu, Lingshan
2023-09-06  8:16 ` [virtio-comment] [PATCH 2/5] virtio: introduce SUSPEND bit in device status Zhu Lingshan
2023-09-14 11:34   ` [virtio-comment] " Michael S. Tsirkin
2023-09-15  2:57     ` Zhu, Lingshan
2023-09-15 11:10       ` Michael S. Tsirkin
2023-09-18  2:56         ` Zhu, Lingshan
2023-09-18  4:42           ` Parav Pandit
2023-09-18  5:14             ` Zhu, Lingshan
2023-09-18  6:17               ` Parav Pandit
2023-09-18  6:38                 ` Zhu, Lingshan
2023-09-18  6:46                   ` Parav Pandit
2023-09-18  6:49                     ` Zhu, Lingshan
2023-09-18  6:50           ` Zhu, Lingshan
2023-09-06  8:16 ` [virtio-comment] [PATCH 3/5] virtqueue: constraints for virtqueue state Zhu Lingshan
2023-09-14 11:30   ` [virtio-comment] " Michael S. Tsirkin
2023-09-15  2:59     ` Zhu, Lingshan
2023-09-15 11:16       ` Michael S. Tsirkin
2023-09-18  3:02         ` Zhu, Lingshan
2023-09-18 17:30           ` Michael S. Tsirkin
2023-09-19  7:56             ` Zhu, Lingshan
2023-09-06  8:16 ` [virtio-comment] [PATCH 4/5] virtqueue: ignore resetting vqs when SUSPEND Zhu Lingshan
2023-09-14 11:09   ` [virtio-comment] " Michael S. Tsirkin
2023-09-15  4:06     ` Zhu, Lingshan
2023-09-06  8:16 ` [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE Zhu Lingshan
2023-09-06  8:32   ` Michael S. Tsirkin
2023-09-06  8:37     ` Parav Pandit
2023-09-06  9:37     ` Zhu, Lingshan
2023-09-11  3:01     ` Jason Wang
2023-09-11  4:11       ` Parav Pandit
2023-09-11  6:30         ` Jason Wang
2023-09-11  6:47           ` Parav Pandit
2023-09-11  6:58             ` Zhu, Lingshan
2023-09-11  7:07               ` Parav Pandit
2023-09-11  7:18                 ` Zhu, Lingshan
2023-09-11  7:30                   ` Parav Pandit
2023-09-11  7:58                     ` Zhu, Lingshan
2023-09-11  8:12                       ` Parav Pandit
2023-09-11  8:46                         ` Zhu, Lingshan
2023-09-11  9:05                           ` Parav Pandit
2023-09-11  9:32                             ` Zhu, Lingshan
2023-09-11 10:21                               ` Parav Pandit
2023-09-12  4:06                                 ` Zhu, Lingshan
2023-09-12  5:58                                   ` Parav Pandit
2023-09-12  6:33                                     ` Zhu, Lingshan
2023-09-12  6:47                                       ` Parav Pandit
2023-09-12  7:27                                         ` Zhu, Lingshan
2023-09-12  7:40                                           ` Parav Pandit
2023-09-12  9:02                                             ` Zhu, Lingshan
2023-09-12  9:21                                               ` Parav Pandit
2023-09-12 13:03                                                 ` Zhu, Lingshan
2023-09-12 13:43                                                   ` Parav Pandit
2023-09-13  4:01                                                     ` Zhu, Lingshan
2023-09-13  4:12                                                       ` Parav Pandit
2023-09-13  4:20                                                         ` Zhu, Lingshan
2023-09-13  4:36                                                           ` Parav Pandit
2023-09-14  8:19                                                             ` Zhu, Lingshan
2023-09-11 11:50                               ` Parav Pandit
2023-09-12  3:43                                 ` Jason Wang
2023-09-12  5:50                                   ` Parav Pandit
2023-09-13  4:44                                     ` Jason Wang
2023-09-13  6:05                                       ` Parav Pandit
2023-09-14  3:11                                         ` Jason Wang
2023-09-17  5:22                                           ` Parav Pandit
2023-09-19  4:35                                             ` Jason Wang
2023-09-19  7:33                                               ` Parav Pandit
2023-09-12  3:48                                 ` Zhu, Lingshan
2023-09-12  5:51                                   ` Parav Pandit
2023-09-12  6:37                                     ` Zhu, Lingshan
2023-09-12  6:49                                       ` Parav Pandit
2023-09-12  7:29                                         ` Zhu, Lingshan
2023-09-12  7:53                                           ` Parav Pandit
2023-09-12  9:06                                             ` Zhu, Lingshan
2023-09-12  9:08                                               ` Zhu, Lingshan
2023-09-12  9:35                                                 ` Parav Pandit
2023-09-12 10:14                                                   ` Zhu, Lingshan
2023-09-12 10:16                                                     ` Parav Pandit
2023-09-12 10:28                                                       ` Zhu, Lingshan
2023-09-13  2:23                                                     ` Parav Pandit
2023-09-13  4:03                                                       ` Zhu, Lingshan
2023-09-13  4:15                                                         ` Parav Pandit
2023-09-13  4:21                                                           ` Zhu, Lingshan
2023-09-13  4:37                                                             ` Parav Pandit
2023-09-14  3:11                                                               ` Jason Wang
2023-09-17  5:25                                                                 ` Parav Pandit
2023-09-19  4:34                                                                   ` Jason Wang
2023-09-19  7:32                                                                     ` Parav Pandit
2023-09-14  8:22                                                               ` Zhu, Lingshan
2023-09-12  9:28                                               ` Parav Pandit
2023-09-12 10:17                                                 ` Zhu, Lingshan
2023-09-12 10:25                                                   ` Parav Pandit
2023-09-12 10:32                                                     ` Zhu, Lingshan
2023-09-12 10:40                                                       ` Parav Pandit
2023-09-12 13:04                                                         ` Zhu, Lingshan
2023-09-12 13:36                                                           ` Parav Pandit
2023-09-12  4:10                         ` Jason Wang
2023-09-12  6:05                           ` Parav Pandit
2023-09-13  4:45                             ` Jason Wang
2023-09-13  6:39                               ` Parav Pandit
2023-09-14  3:08                                 ` Jason Wang
2023-09-17  5:22                                   ` Parav Pandit
2023-09-19  4:32                                     ` Jason Wang
2023-09-19  7:32                                       ` Parav Pandit
2023-09-13  8:27                               ` Michael S. Tsirkin
2023-09-14  3:11                                 ` Jason Wang
2023-09-12  4:18             ` Jason Wang
2023-09-12  6:11               ` Parav Pandit
2023-09-12  6:43                 ` Zhu, Lingshan
2023-09-12  6:52                   ` Parav Pandit
2023-09-12  7:36                     ` Zhu, Lingshan
2023-09-12  7:43                       ` Parav Pandit
2023-09-12 10:27                         ` Zhu, Lingshan
2023-09-12 10:33                           ` Parav Pandit
2023-09-12 10:35                             ` Zhu, Lingshan
2023-09-12 10:41                               ` Parav Pandit
2023-09-12 13:09                                 ` Zhu, Lingshan
2023-09-12 13:35                                   ` Parav Pandit
2023-09-13  4:13                                     ` Zhu, Lingshan
2023-09-13  4:19                                       ` Parav Pandit
2023-09-13  4:22                                         ` Zhu, Lingshan
2023-09-13  4:39                                           ` Parav Pandit
2023-09-14  8:24                                             ` Zhu, Lingshan
2023-09-13  4:56                                         ` Jason Wang
2023-09-13  4:43                 ` Jason Wang
2023-09-13  4:46                   ` Parav Pandit
2023-09-14  3:12                     ` Jason Wang
2023-09-17  5:29                       ` Parav Pandit
2023-09-19  4:25                         ` Jason Wang
2023-09-19  7:32                           ` Parav Pandit
2023-09-11  6:59           ` Parav Pandit
2023-09-11 10:15           ` Michael S. Tsirkin
2023-09-12  3:35             ` Jason Wang
2023-09-12  3:43               ` Zhu, Lingshan
2023-09-14 11:27   ` Michael S. Tsirkin
2023-09-15  4:13     ` Zhu, Lingshan
2023-09-06  8:29 ` [virtio-comment] [PATCH 0/5] virtio: introduce SUSPEND bit and vq state Michael S. Tsirkin
2023-09-06  8:38   ` Zhu, Lingshan [this message]
2023-09-06 13:49     ` Michael S. Tsirkin
2023-09-07  1:51       ` Zhu, Lingshan
2023-09-07 10:57       ` Eugenio Perez Martin
2023-09-07 19:55         ` Michael S. Tsirkin
2023-09-14 11:14 ` [virtio-comment] " Michael S. Tsirkin
2023-09-14 11:37 ` Michael S. Tsirkin
2023-09-15  4:41   ` [virtio-comment] Re: [virtio-dev] " Zhu, Lingshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa6101cc-caf6-95e9-89cd-614ac7a43e55@intel.com \
    --to=lingshan.zhu@intel.com \
    --cc=cohuck@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox