From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0739C76196 for ; Thu, 16 Mar 2023 13:45:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id DBB4D370ED for ; Thu, 16 Mar 2023 13:45:33 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id D1EC898641F for ; Thu, 16 Mar 2023 13:45:33 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id C2B29983E51; Thu, 16 Mar 2023 13:45:33 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id AF8809863D7; Thu, 16 Mar 2023 13:45:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=hengqi@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0Ve.SsCl_1678974327; Message-ID: Date: Thu, 16 Mar 2023 21:45:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: Parav Pandit , "Michael S. Tsirkin" Cc: virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, Jason Wang , Yuri Benditovich , Cornelia Huck , Xuan Zhuo References: <20230306154817.14115-1-hengqi@linux.alibaba.com> <20230315075954-mutt-send-email-mst@kernel.org> <11cce86e-8068-2e83-9fc5-e1b825adde29@nvidia.com> From: Heng Qi In-Reply-To: <11cce86e-8068-2e83-9fc5-e1b825adde29@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash 在 2023/3/16 上午7:24, Parav Pandit 写道: > > On 3/15/2023 8:10 AM, Michael S. Tsirkin wrote: >> On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote: >>> If not, for now it may be better to skip vxlan and nvegre as they >>> inherently >>> have unique outer header UDP src port based on the inner header. >> >> So what's left, GRE?  GRE is actually different, in that it's not IP at >> all. > Sorry, I wrongly wrote nvegre above. > > IPoIP, GRE and NVGRE are left. > > vxlan and geneve has the udp src entropy. > >> > Not sure I understand "its not IP at all". > > GRE has outer IP header + GRE header with the key to identify the flow. > The key is effectively the hash for the flow. > >> So if we are talking about GRE, hash is indeed not calculated at all at >> the moment, right? > Hash of the outer IP header of the src and dst IP can be still > calculated currently for GRE when the optional key is not present. > >> And I would say a natural first step for GRE is >> actually adding a hash type that will support this protocol. >> > For GRE and NVGRE GRE_header.key as the flow/hash identifier should > work without inner header hash. > Older version of the GRE doesn't have key, so inner header hash is > useful. Yes, indeed. The old GRE does not have keys such as flow id. Even with the new GRE, we have no chance to use optional fields, because we have connected with various operators, and the most basic fields can get the best compatibility. Thanks. > >> How about doing that? It seems like this should be a small step >> and completely uncontroversial. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/