From: Paolo Abeni <pabeni@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Parav Pandit <parav@nvidia.com>,
virtio-comment@lists.linux.dev, cohuck@redhat.com,
mvaralar@redhat.com, shahafs@nvidia.com,
Willem de Bruijn <willemb@google.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH v1] virtio-net: Fix to avoid using reserved feature bits
Date: Mon, 28 Apr 2025 19:07:12 +0200 [thread overview]
Message-ID: <f2bf47cf-e789-4f41-aa6a-68adfd887504@redhat.com> (raw)
In-Reply-To: <20250428045124-mutt-send-email-mst@kernel.org>
Hi,
I'll try to consolidate here the current discussion.
My understanding is that the we are on same WRT that there is a problem
with the current spec.
On 4/28/25 11:13 AM, Michael S. Tsirkin wrote:
> Given features are negotiated first, we can just say the value
> can be 64 or 128 bits? In any case, I agree it's buggy as defined.
Do you mean that the 'offload' field should be 64 or 128 bits long
depending on the negotiated features?
Could that be problematic with VM migrations and/or backward
compatibility? I can't see a specific faulty scenario, but the 'implied'
field size sounds fragile to me.
/P
next prev parent reply other threads:[~2025-04-28 17:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 6:20 [PATCH v1] virtio-net: Fix to avoid using reserved feature bits Parav Pandit
2025-01-26 9:19 ` Michael S. Tsirkin
2025-01-26 16:44 ` Parav Pandit
2025-01-26 16:50 ` Michael S. Tsirkin
2025-01-27 9:21 ` Cornelia Huck
2025-01-27 12:54 ` Parav Pandit
2025-04-22 17:49 ` Paolo Abeni
2025-04-23 5:46 ` Michael S. Tsirkin
2025-04-23 16:05 ` Paolo Abeni
2025-04-28 9:13 ` Michael S. Tsirkin
2025-04-28 17:07 ` Paolo Abeni [this message]
2025-04-28 17:18 ` Michael S. Tsirkin
2025-04-23 16:29 ` Daniel Verkamp
2025-04-23 18:07 ` Michael S. Tsirkin
2025-04-28 8:39 ` Paolo Abeni
2025-04-28 8:47 ` Michael S. Tsirkin
2025-04-29 20:43 ` Michael S. Tsirkin
2025-04-30 4:44 ` Parav Pandit
2025-04-30 5:25 ` Yuri Benditovich
2025-04-30 5:44 ` Parav Pandit
2025-04-30 10:12 ` Paolo Abeni
2025-04-30 10:54 ` Parav Pandit
2025-05-01 13:42 ` Michael S. Tsirkin
2025-05-01 15:57 ` Paolo Abeni
2025-05-06 6:15 ` Parav Pandit
2025-05-06 7:56 ` Michael S. Tsirkin
2025-05-06 8:56 ` Parav Pandit
2025-05-06 14:38 ` Paolo Abeni
2025-05-06 15:00 ` Parav Pandit
2025-05-06 15:40 ` Paolo Abeni
2025-05-06 16:20 ` Parav Pandit
2025-05-07 9:57 ` Paolo Abeni
2025-05-08 6:15 ` Michael S. Tsirkin
2025-05-19 8:57 ` Paolo Abeni
2025-05-19 9:04 ` Parav Pandit
2025-05-19 9:24 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2bf47cf-e789-4f41-aa6a-68adfd887504@redhat.com \
--to=pabeni@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=mvaralar@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.linux.dev \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox