Re: [PATCH v2 1/1] virtio-blk: Add description for blk_size field

Stefan Hajnoczi
2024-10-08T20:15:12Z

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Sun, Oct 06, 2024 at 07:56:09PM +0300, Max Gurtovoy wrote:
> This field is only valid when the VIRTIO_BLK_F_BLK_SIZE feature bit is
> offered by the device.
>
> The blk_size field actually represents the logical block size of the
> device. It is always a power of two and typically ranges from 512 bytes
> to larger values such as 4 KB.
>
> Add description for this field to provide clarity on its constraints.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>
> changes from V1:
> - Addressed Stefan's and Daniel's comments:
> 1. use SHOULD instead of MUST
> 2. Add a note that devices may return IOERR upon misaligned IO
> - Add a note that devices may return IOERR if IO size is not following
> the block size granularity.
> ---
> device-types/blk/description.tex | 34 ++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]