Re: [PATCH v2 1/1] virtio-blk: Add description for blk_size field

Max Gurtovoy
2024-10-08T22:46:26Z

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

On 08/10/2024 23:15, Stefan Hajnoczi wrote:
> On Sun, Oct 06, 2024 at 07:56:09PM +0300, Max Gurtovoy wrote:
>> This field is only valid when the VIRTIO_BLK_F_BLK_SIZE feature bit is
>> offered by the device.
>>
>> The blk_size field actually represents the logical block size of the
>> device. It is always a power of two and typically ranges from 512 bytes
>> to larger values such as 4 KB.
>>
>> Add description for this field to provide clarity on its constraints.
>>
>> Signed-off-by: Max Gurtovoy<mgurtovoy@nvidia.com>
>> ---
>>
>> changes from V1:
>> - Addressed Stefan's and Daniel's comments:
>> 1. use SHOULD instead of MUST
>> 2. Add a note that devices may return IOERR upon misaligned IO
>> - Add a note that devices may return IOERR if IO size is not following
>> the block size granularity.
>> ---
>> device-types/blk/description.tex | 34 ++++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
> Reviewed-by: Stefan Hajnoczi<stefanha@redhat.com>

I'll add both yours and Daniel's Reviewed-by signatures and fix a small
comment from Daniel.

Can you please remind me the next step I should do ?

Should I open an issue at the oasis github and mention it as "Fixes: "
in the commit message ?

[-- Attachment #2: Type: text/html, Size: 2155 bytes --]