From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Subject: [virtio] [PATCH v6 5/5] packed-ring: add in order request support
Date: Wed, 10 Jan 2018 11:47:59 +0200 [thread overview]
Message-ID: <1515577653-9336-6-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1515577653-9336-1-git-send-email-mst@redhat.com>
support in-order requests for packed rings. more work is needed to use
them efficiently for split rings (e.g. it makes sense to bypass
avail/used rings in this case), forbid that combination for now.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
content.tex | 7 +++++++
packed-ring.tex | 24 ++++++++++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/content.tex b/content.tex
index 3059bd3..f478ae2 100644
--- a/content.tex
+++ b/content.tex
@@ -5240,6 +5240,10 @@ and .
\item[VIRTIO_F_RING_PACKED(34)] This feature indicates
support for the packed virtqueue layout as described in
\ref{sec:Basic Facilities of a Virtio Device / Packed Virtqueues}.
+ \item[VIRTIO_F_IN_ORDER(35)] This feature indicates
+ that all buffers are used by the device in the same
+ order in which they have been made available.
+ This feature should only be enabled with VIRTIO_F_RING_PACKED.
\end{description}
\drivernormative{\section}{Reserved Feature Bits}{Reserved Feature Bits}
@@ -5255,6 +5259,9 @@ addresses to the device.
A driver SHOULD accept VIRTIO_F_PACKED_RING if it is offered.
+A driver MUST only accept VIRTIO_F_IN_ORDER if it also accepts
+VIRTIO_F_RING_PACKED.
+
\devicenormative{\section}{Reserved Feature Bits}{Reserved Feature Bits}
A device MUST offer VIRTIO_F_VERSION_1. A device MAY fail to operate further
diff --git a/packed-ring.tex b/packed-ring.tex
index ffc699c..88d121c 100644
--- a/packed-ring.tex
+++ b/packed-ring.tex
@@ -260,6 +260,30 @@ Buffer ID is also reserved and is ignored by the device.
In Descriptors with VIRTQ_DESC_F_INDIRECT set VIRTQ_DESC_F_WRITE
is reserved and is ignored by the device.
+\subsection{In-order use of descriptors}
+\label{sec:Packed Virtqueues / In-order use of descriptors}
+
+Some devices always use descriptors in the same order in which
+they have been made available. These devices can offer the
+VIRTIO_F_IN_ORDER feature. If negotiated, this knowledge allows
+devices to notify the use of a batch of buffers to the driver by
+only writing out a single used descriptor with the Buffer ID
+corresponding to the last descriptor in the batch.
+
+Device then skips forward in the ring according to the size of
+the batch. Driver needs to look up the used Buffer ID and
+calculate the batch size to be able to advance to where the next
+used descriptor will be written by the device.
+
+This will result in the used descriptor overwriting the first
+available descriptor in the batch, the used descriptor for the
+next batch overwriting the first available descriptor in the next
+batch, etc.
+
+The skipped buffers (for which no used descriptor was written)
+are assumed to have been used (read or written) by the
+device completely.
+
\subsection{Multi-buffer requests}
\label{sec:Packed Virtqueues / Multi-descriptor batches}
Some devices combine multiple buffers as part of processing of a
--
MST
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
next prev parent reply other threads:[~2018-01-10 9:47 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 9:47 [virtio] [PATCH v6 0/5] packed ring layout spec Michael S. Tsirkin
2018-01-10 9:47 ` [virtio] [PATCH v6 1/5] content: move 1.0 queue format out to a separate section Michael S. Tsirkin
2018-01-10 12:45 ` Cornelia Huck
2018-01-10 9:47 ` [virtio] [PATCH v6 2/5] content: move ring text out to a separate file Michael S. Tsirkin
2018-01-10 12:46 ` Cornelia Huck
2018-01-10 9:47 ` [virtio] [PATCH v6 3/5] content: move virtqueue operation description Michael S. Tsirkin
2018-01-10 12:48 ` Cornelia Huck
2018-01-10 9:47 ` [virtio] [PATCH v6 4/5] packed virtqueues: more efficient virtqueue layout Michael S. Tsirkin
2018-01-10 10:47 ` Cornelia Huck
2018-01-10 13:49 ` [virtio-dev] " Jens Freimann
2018-01-10 14:39 ` [virtio] " Michael S. Tsirkin
2018-01-10 14:08 ` Tiwei Bie
2018-01-10 14:39 ` [virtio] " Michael S. Tsirkin
2018-01-10 14:15 ` [virtio] " Cornelia Huck
2018-01-10 15:37 ` Michael S. Tsirkin
2018-01-10 9:47 ` Michael S. Tsirkin [this message]
2018-01-10 10:33 ` [virtio] [PATCH v6 0/5] packed ring layout spec Cornelia Huck
2018-01-10 11:10 ` Michael S. Tsirkin
2018-01-10 11:14 ` Cornelia Huck
2018-01-10 11:16 ` Michael S. Tsirkin
2018-01-23 0:01 ` [virtio] [PATCH v7 02/11] content: move ring text out to a separate file Michael S. Tsirkin
2018-01-30 10:07 ` Cornelia Huck
2018-01-23 0:01 ` [virtio] [PATCH v7 01/11] content: move 1.0 queue format out to a separate section Michael S. Tsirkin
2018-01-30 10:06 ` Cornelia Huck
2018-02-05 22:54 ` Halil Pasic
2018-02-06 0:05 ` Michael S. Tsirkin
2018-02-06 8:38 ` Cornelia Huck
2018-02-06 11:10 ` [virtio] Re: [virtio-dev] " Halil Pasic
2018-02-06 11:20 ` Cornelia Huck
2018-02-06 12:03 ` Halil Pasic
2018-02-06 22:58 ` Michael S. Tsirkin
2018-01-23 0:01 ` [virtio] [PATCH v7 03/11] content: move virtqueue operation description Michael S. Tsirkin
2018-01-30 10:12 ` Cornelia Huck
2018-01-23 0:01 ` [virtio] [PATCH v7 04/11] content: replace mentions of len with used length Michael S. Tsirkin
2018-01-30 10:16 ` Cornelia Huck
2018-01-30 16:38 ` Michael S. Tsirkin
2018-01-23 0:01 ` [virtio] [PATCH v7 05/11] content: generalize transport ring part naming Michael S. Tsirkin
2018-01-30 10:27 ` Cornelia Huck
2018-01-23 0:01 ` [virtio] [PATCH v7 06/11] content: generalize rest of text Michael S. Tsirkin
2018-01-30 10:31 ` Cornelia Huck
2018-01-30 16:40 ` Michael S. Tsirkin
2018-01-23 0:01 ` [virtio] [PATCH v7 07/11] split-ring: generalize text Michael S. Tsirkin
2018-01-30 10:45 ` Cornelia Huck
2018-01-30 16:42 ` Michael S. Tsirkin
2018-01-23 0:01 ` [virtio] [PATCH v7 08/11] packed virtqueues: more efficient virtqueue layout Michael S. Tsirkin
2018-01-30 7:16 ` [virtio-dev] " Tiwei Bie
2018-01-30 16:45 ` [virtio] " Michael S. Tsirkin
2018-01-30 13:07 ` Jens Freimann
2018-01-30 13:50 ` [virtio] " Cornelia Huck
2018-01-30 19:40 ` Michael S. Tsirkin
2018-02-01 3:05 ` [virtio-dev] " Tiwei Bie
2018-02-01 10:11 ` [virtio] " Cornelia Huck
2018-02-01 14:43 ` Michael S. Tsirkin
2018-02-05 11:54 ` Halil Pasic
2018-02-05 14:33 ` Michael S. Tsirkin
2018-02-05 16:57 ` Halil Pasic
2018-02-05 17:00 ` Paolo Bonzini
2018-02-05 18:16 ` Cornelia Huck
2018-02-05 18:21 ` Michael S. Tsirkin
2018-02-05 18:26 ` Cornelia Huck
2018-02-05 17:55 ` Michael S. Tsirkin
2018-02-05 22:57 ` [virtio] Re: [virtio-dev] " Halil Pasic
2018-01-23 0:01 ` [virtio] [PATCH v7 09/11] content: in-order buffer use Michael S. Tsirkin
2018-02-01 11:01 ` Cornelia Huck
2018-02-12 13:18 ` Stefan Hajnoczi
2018-01-23 0:01 ` [virtio] [PATCH v7 10/11] packed-ring: add in order support Michael S. Tsirkin
2018-02-02 11:03 ` Cornelia Huck
2018-02-12 13:22 ` Stefan Hajnoczi
2018-01-23 0:01 ` [virtio] [PATCH v7 11/11] split-ring: in order feature Michael S. Tsirkin
2018-02-02 11:06 ` Cornelia Huck
2018-02-12 13:23 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515577653-9336-6-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox