From: Halil Pasic <pasic@linux.ibm.com>
To: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Pawel Moll <pawel.moll@arm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>
Subject: [virtio] [PATCH v2 4/6] pci: map common notifications terminology to PCI
Date: Mon, 11 Jun 2018 18:11:56 +0200 [thread overview]
Message-ID: <1528733518-24950-5-git-send-email-pasic@linux.ibm.com> (raw)
In-Reply-To: <1528733518-24950-1-git-send-email-pasic@linux.ibm.com>
The various notifications are introduced and specified in the common
(i.e. transport agnostic) portion of this specification. How
notifications are realised for a given transport is something each
transport has to specify.
Let's make the relationship between the PCI terms and the common
terms more obvious.
Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
---
conformance.tex | 2 +-
content.tex | 13 +++++++------
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/conformance.tex b/conformance.tex
index de33396..29969f1 100644
--- a/conformance.tex
+++ b/conformance.tex
@@ -180,7 +180,7 @@ A PCI device MUST conform to the following normative statements:
\item \ref{devicenormative:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / PCI configuration access capability}
\item \ref{devicenormative:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Non-transitional Device With Legacy Driver}
\item \ref{devicenormative:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / MSI-X Vector Configuration}
-\item \ref{devicenormative:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Virtqueue Interrupts From The Device}
+\item \ref{devicenormative:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Used Buffer Notifications}
\item \ref{devicenormative:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Notification of Device Configuration Changes}
\end{itemize}
diff --git a/content.tex b/content.tex
index 297e9a4..98efdd2 100644
--- a/content.tex
+++ b/content.tex
@@ -941,7 +941,7 @@ causes the device to de-assert the interrupt.
In this way, driver read of ISR status causes the device to de-assert
an interrupt.
-See sections \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Virtqueue Interrupts From The Device} and \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Notification of Device Configuration Changes} for how this is used.
+See sections \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Used Buffer Notifications} and \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Notification of Device Configuration Changes} for how this is used.
\devicenormative{\paragraph}{ISR status capability}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / ISR status capability}
@@ -1306,14 +1306,15 @@ enough to ensure that the separate parts of the virtqueue are on
separate cache lines.
}. There was no mechanism to negotiate the queue size.
-\subsubsection{Notifying The Device}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Notifying The Device}
+\subsubsection{Available Buffer Notifications}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Available Buffer Notifications}
-The driver notifies the device by writing the 16-bit virtqueue index
+The driver sends an available buffer notification to the device by writing
+the 16-bit virtqueue index
of this virtqueue to the Queue Notify address. See \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Notification capability} for how to calculate this address.
-\subsubsection{Virtqueue Interrupts From The Device}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Virtqueue Interrupts From The Device}
+\subsubsection{Used Buffer Notifications}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Used Buffer Notifications}
-If an interrupt is necessary for a virtqueue, the device would typically act as follows:
+If a used buffer notification is necessary for a virtqueue, the device would typically act as follows:
\begin{itemize}
\item If MSI-X capability is disabled:
@@ -1332,7 +1333,7 @@ If an interrupt is necessary for a virtqueue, the device would typically act as
\end{enumerate}
\end{itemize}
-\devicenormative{\paragraph}{Virtqueue Interrupts From The Device}{Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Virtqueue Interrupts From The Device}
+\devicenormative{\paragraph}{Used Buffer Notifications}{Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Used Buffer Notifications}
If MSI-X capability is enabled and \field{queue_msix_vector} is
NO_VECTOR for a virtqueue, the device MUST NOT deliver an interrupt
--
1.7.1
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
next prev parent reply other threads:[~2018-06-11 16:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 16:11 [virtio] [PATCH v2 0/6] rework notifications terminology Halil Pasic
2018-06-11 16:11 ` [virtio] [PATCH v2 1/6] notifications: unify notifications wording in core Halil Pasic
2018-06-13 9:44 ` [virtio] " Cornelia Huck
2018-06-13 13:14 ` Halil Pasic
2018-06-13 13:04 ` Stefan Hajnoczi
2018-06-13 13:22 ` Halil Pasic
2018-06-11 16:11 ` [virtio] [PATCH v2 2/6] notifications: notifications as basic virtio facility Halil Pasic
2018-06-13 9:48 ` [virtio] " Cornelia Huck
2018-06-13 13:07 ` Stefan Hajnoczi
2018-06-13 13:38 ` Halil Pasic
2018-06-11 16:11 ` [virtio] [PATCH v2 3/6] ccw: map common notifications terminology to ccw Halil Pasic
2018-06-13 9:50 ` [virtio] " Cornelia Huck
2018-06-11 16:11 ` Halil Pasic [this message]
2018-06-13 9:51 ` [virtio] Re: [PATCH v2 4/6] pci: map common notifications terminology to PCI Cornelia Huck
2018-06-11 16:11 ` [virtio] [PATCH v2 5/6] mmio: map common notifications terminology to MMIO Halil Pasic
2018-06-13 9:59 ` [virtio] " Cornelia Huck
2018-06-11 16:11 ` [virtio] [PATCH v2 6/6] notifications: update notifications terminology for devices Halil Pasic
2018-06-13 10:00 ` [virtio] " Cornelia Huck
2018-06-13 13:09 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528733518-24950-5-git-send-email-pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pawel.moll@arm.com \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox