From: Halil Pasic <pasic@linux.ibm.com>
To: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Pawel Moll <pawel.moll@arm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>
Subject: [virtio] [PATCH v3 6/6] notifications: update notifications terminology for devices
Date: Mon, 25 Jun 2018 14:21:32 +0200 [thread overview]
Message-ID: <1529929292-11900-7-git-send-email-pasic@linux.ibm.com> (raw)
In-Reply-To: <1529929292-11900-1-git-send-email-pasic@linux.ibm.com>
The specifications of some virtio device types are still using the old
terminology for used buffer notifications and configuration change
notifications calling these interrupts.
Let us fix that.
Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
content.tex | 22 +++++++++++-----------
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/content.tex b/content.tex
index 5919cc1..097af44 100644
--- a/content.tex
+++ b/content.tex
@@ -3043,9 +3043,9 @@ if VIRTIO_NET_F_MRG_RXBUF is not negotiated.}
\label{sec:Device Types / Network Device / Device Operation / Processing of Packets}%old label for latexdiff
When a packet is copied into a buffer in the receiveq, the
-optimal path is to disable further interrupts for the receiveq
-and process
-packets until no more are found, then re-enable them.
+optimal path is to disable further used buffer notifications for the
+receiveq and process packets until no more are found, then re-enable
+them.
Processing incoming packets involves:
@@ -3885,7 +3885,7 @@ The device SHOULD clear the \field{write_zeroes_may_unmap} field of the
virtio configuration space if and only if a write zeroes request cannot
result in deallocating one or more sectors. The device MAY change the
content of the field during operation of the device; when this happens,
-the device SHOULD trigger a configuration change interrupt.
+the device SHOULD trigger a configuration change notification.
A write is considered volatile when it is submitted; the contents of
sectors covered by a volatile write are undefined in persistent device
@@ -4177,20 +4177,20 @@ an appropriate log or output method.
\begin{enumerate}
\item For output, a buffer containing the characters is placed in
the port's transmitq\footnote{Because this is high importance and low bandwidth, the current
-Linux implementation polls for the buffer to be used, rather than
-waiting for an interrupt, simplifying the implementation
+Linux implementation polls for the buffer to become used, rather than
+waiting for a used buffer notification, simplifying the implementation
significantly. However, for generic serial ports with the
O_NONBLOCK flag set, the polling limitation is relaxed and the
consumed buffers are freed upon the next write or poll call or
when a port is closed or hot-unplugged.
}.
-\item When a buffer is used in the receiveq (signalled by an
- interrupt), the contents is the input to the port associated
+\item When a buffer is used in the receiveq (signalled by a
+ used buffer notification), the contents is the input to the port associated
with the virtqueue for which the notification was received.
\item If the driver negotiated the VIRTIO_CONSOLE_F_SIZE feature, a
- configuration change interrupt indicates that the updated size can
+ configuration change notification indicates that the updated size can
be read from the configuration fields. This size applies to port 0 only.
\item If the driver negotiated the VIRTIO_CONSOLE_F_MULTIPORT
@@ -4433,7 +4433,7 @@ The device initialization process is outlined below:
\subsection{Device Operation}\label{sec:Device Types / Memory Balloon Device / Device Operation}
The device is driven either by the receipt of a configuration
-change interrupt, or by changing guest memory needs, such as
+change notification, or by changing guest memory needs, such as
performing memory compaction or responding to out of memory
conditions.
@@ -4570,7 +4570,7 @@ and notifies the device. A request for memory statistics proceeds
as follows:
\begin{enumerate}
-\item The device uses the buffer and sends an interrupt.
+\item The device uses the buffer and sends a used buffer notification.
\item The driver pops the used buffer and discards it.
--
1.7.1
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
next prev parent reply other threads:[~2018-06-25 12:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 12:21 [virtio] [PATCH v3 0/6] rework notifications terminology Halil Pasic
2018-06-25 12:21 ` [virtio] [PATCH v3 1/6] notifications: unify notifications wording in core Halil Pasic
2018-06-25 14:45 ` [virtio] " Cornelia Huck
2018-06-25 15:15 ` [virtio] Re: [virtio-dev] " Halil Pasic
2018-06-25 12:21 ` [virtio] [PATCH v3 2/6] notifications: notifications as basic virtio facility Halil Pasic
2018-06-25 14:37 ` [virtio] " Cornelia Huck
2018-06-25 12:21 ` [virtio] [PATCH v3 3/6] ccw: map common notifications terminology to ccw Halil Pasic
2018-06-25 12:21 ` [virtio] [PATCH v3 4/6] pci: map common notifications terminology to PCI Halil Pasic
2018-06-25 12:21 ` [virtio] [PATCH v3 5/6] mmio: map common notifications terminology to MMIO Halil Pasic
2018-06-25 14:34 ` [virtio] " Cornelia Huck
2018-06-25 12:21 ` Halil Pasic [this message]
2018-07-02 15:51 ` [virtio] Re: [PATCH v3 0/6] rework notifications terminology Stefan Hajnoczi
2018-07-03 0:01 ` [virtio] Re: [virtio-dev] " Michael S. Tsirkin
2018-07-03 7:45 ` Cornelia Huck
2018-07-03 9:00 ` Halil Pasic
2018-07-03 12:07 ` [virtio] Re: [virtio-dev] " Halil Pasic
2018-07-17 16:47 ` Halil Pasic
2018-07-27 11:33 ` Halil Pasic
2018-07-27 11:45 ` Michael S. Tsirkin
2018-08-01 13:04 ` Halil Pasic
2018-08-01 22:30 ` Michael S. Tsirkin
2018-08-02 17:12 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529929292-11900-7-git-send-email-pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pawel.moll@arm.com \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox