From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78AA5EB64D7 for ; Mon, 26 Jun 2023 09:45:26 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id C8A5D7C666 for ; Mon, 26 Jun 2023 09:45:25 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C2B73986408 for ; Mon, 26 Jun 2023 09:45:25 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id B6BC398636F; Mon, 26 Jun 2023 09:45:25 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id A2618986382; Mon, 26 Jun 2023 09:45:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Vm-LwPq_1687772715; Message-ID: <1687772138.9048312-3-xuanzhuo@linux.alibaba.com> Date: Mon, 26 Jun 2023 17:35:38 +0800 From: Xuan Zhuo To: "Michael S. Tsirkin" Cc: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, parav@nvidia.com References: <20230626062210.49020-1-xuanzhuo@linux.alibaba.com> <20230626031704-mutt-send-email-mst@kernel.org> In-Reply-To: <20230626031704-mutt-send-email-mst@kernel.org> Subject: [virtio-dev] Re: [virtio-comment] Re: [RFC PATCH] admin-queue: bind the group member to the device On Mon, 26 Jun 2023 05:32:47 -0400, "Michael S. Tsirkin" wrote: > On Mon, Jun 26, 2023 at 02:22:10PM +0800, Xuan Zhuo wrote: > > The VFs of the SR-IOV are created by the user inside the guest OS, so the virtio > > devices don't know about these VFs. Because each VF may be assigned a different role > > by the user, the virtio device can not choose one VF to bind random. > > So only the user knows how to bind the virtio devices to the VFs. > > On the other hand, generally the virtio devices are not created by the user > > inside the guest OS. This requires some management platform to participate. > > > > So the usage of this command: > > 1. The user purchases a virtio network card on the management platform, > > and sets the ip, queue number, etc. The user obtains the identity of > > the network card. > > 2. The user creates a VF with echo 8 > sriov_numvfs > > this one is unlikely, as this requires PF access and affects all VFs. How do you create VFs? > > > 3. The user binds the net crad to a VF with identity through the command > > of the patch > > > > Signed-off-by: Xuan Zhuo > > > > > > --- > > admin.tex | 41 ++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 40 insertions(+), 1 deletion(-) > > > > diff --git a/admin.tex b/admin.tex > > index 2efd4d7..64d0667 100644 > > --- a/admin.tex > > +++ b/admin.tex > > @@ -115,7 +115,8 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti > > \hline \hline > > 0x0000 & VIRTIO_ADMIN_CMD_LIST_QUERY & Provides to driver list of commands supported for this group type \\ > > 0x0001 & VIRTIO_ADMIN_CMD_LIST_USE & Provides to device list of commands used for this group type \\ > > -0x0002 - 0x7FFF & - & Commands using \field{struct virtio_admin_cmd} \\ > > +0x0002 & VIRTIO_ADMIN_CMD_BIND_DEVICE & Bind the device to one group member \\ > > +0x0003 - 0x7FFF & - & Commands using \field{struct virtio_admin_cmd} \\ > > \hline > > 0x8000 - 0xFFFF & - & Reserved for future commands (possibly using a different structure) \\ > > \hline > > @@ -429,6 +430,44 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti > > \field{VF Enable} refer to registers within the SR-IOV Extended > > Capability as specified by \hyperref[intro:PCIe]{[PCIe]}. > > > > +\subsubsection{Bind the device for member} > > + > > +The VFs of the SR-IOV are created by the user inside the guest OS, so the virtio > > +devices don't know about these VFs. > > I don't really get how. Maybe there is something wrong with my expression. The backend can know these vfs, but it doesn't know which vf should be bound to which backend. > > > Because each VF may be assigned a different role > > +by the user, the virtio device can not choose one VF to bind random. > > +So only the user knows how to bind the virtio devices to the VFs. > > +On the other hand, generally the virtio devices are not created by the user > > +inside the guest OS. This requires some management platform to participate. > > + > > +So we introduce a new admin queue command to bind the VFs and the virtio > > +devices. > > This description needs a complete rewrite, but to try to help you I'd > need to figure out what is being said. My guess is that this is an > attempt to introduce some kind of identity to VFs. OK but what is this NO. An identity for the device in the backend. > identity and how is it better than using VF#? You want it to persist > when NumVFs in the SR-IOV capability changes? > > > +\begin{lstlisting} > > +struct virtio_admin_cmd_bind { > > + u64 identity; > > +}; > > +\end{lstlisting} > > + > > +The user got the \field{identity} from the management platform, that is not > > +included by this spec. > > Without even understanding the above, what I don't like about this > proposal, is that it assumes some out of band interface to either > specify or discover these IDs. This is an rfc, and I actually don't like this proposal too. But I want to raise this issue, this is a real problem, and I hope to find a standardized solution. I don't want us to create a private solution internally. Thanks. > With admin commands we now have > ability to fully specify a management interface, and I'd rather > we had a complete proposal covering all aspects of it. > If some platform does not want to use the management aspects, > that's ok. > > > + > > +\drivernormative{\paragraph}{Group administration commands}{Basic Facilities of a Virtio Device / Device groups / Group administration commands / Bind the device for member} > > + > > +VIRTIO_ADMIN_CMD_BIND_DEVICE requires that the \field{group_member_id} MUST be set. > > + > > +The \field{identity} is passed by the user. It is the identity of the virtio > > +device. > > + > > +\devicenormative{\paragraph}{Group administration commands}{Basic Facilities of a Virtio Device / Device groups / Group administration commands / Bind the device for member} > > + > > +Every device MUST have one unique \field{identity} in the host. > > + > > +If the PF device can not find the device by the \field{identity}, > > +the \field{status} MUST be set to VIRTIO_ADMIN_STATUS_EINVAL. > > + > > +If the device is found by the \field{identity}, the device MUST work as the > > +device of this group member specified by the \field{group_member_id}. > > + > > \section{Administration Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Administration Virtqueues} > > > > An administration virtqueue of an owner device is used to submit > > > -- > > 2.32.0.3.g01195cf9f > > > This publicly archived list offers a means to provide input to the > OASIS Virtual I/O Device (VIRTIO) TC. > > In order to verify user consent to the Feedback License terms and > to minimize spam in the list archive, subscription is required > before posting. > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > List help: virtio-comment-help@lists.oasis-open.org > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > Committee: https://www.oasis-open.org/committees/virtio/ > Join OASIS: https://www.oasis-open.org/join/ > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org