public inbox for virtio-dev@lists.linux.dev
 help / color / mirror / Atom feed
From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "jasowang@redhat.com" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	David Edmondson <david.edmondson@oracle.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>
Subject: [virtio-dev] Re: RE: RE: RE: [PATCH v16] virtio-net: support device stats
Date: Mon, 4 Sep 2023 16:52:41 +0800	[thread overview]
Message-ID: <1693817561.0941262-4-xuanzhuo@linux.alibaba.com> (raw)
In-Reply-To: <PH0PR12MB548167EDE78C3B7C00014D2CDCE9A@PH0PR12MB5481.namprd12.prod.outlook.com>

On Mon, 4 Sep 2023 08:08:57 +0000, Parav Pandit <parav@nvidia.com> wrote:
>
> > From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > Sent: Monday, September 4, 2023 1:32 PM
> > > If so, how will the receive device can receive such large packet when the
> > posted buffer is not worth the 64KB size?
> >
> > The virtio-net merge mode.
>
> that is only fine when the mtu is 64K or when mtu is not negotiated.
> Because in spec we have
>
> "The device MUST NOT pass received packets that exceed mtu (plus low level ethernet header length) size
> with gso_type NONE or ECN after VIRTIO_NET_F_MTU has been successfully negotiated."

NO.

If the mtu is 1500, we can pass 64k packets to the driver with gso_type (not NONE).

Thanks.



>
> We need to update the definition of those gso counter to indicate above two conditions.

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-09-04  8:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  5:52 [virtio-dev] [PATCH v16] virtio-net: support device stats Xuan Zhuo
2023-09-01 13:58 ` [virtio-dev] " Parav Pandit
2023-09-01 14:45   ` [virtio-dev] " Michael S. Tsirkin
2023-09-04  7:46     ` [virtio-dev] Re: [virtio-comment] " Xuan Zhuo
2023-09-04  7:33   ` [virtio-dev] Re: " Xuan Zhuo
2023-09-04  8:00     ` [virtio-dev] " Parav Pandit
2023-09-04  8:02       ` [virtio-dev] " Xuan Zhuo
2023-09-04  8:08         ` [virtio-dev] " Parav Pandit
2023-09-04  8:52           ` Xuan Zhuo [this message]
2023-09-04 10:26             ` [virtio-dev] " Parav Pandit
2023-09-04 11:11               ` Heng Qi
2023-09-04 12:21                 ` Parav Pandit
2023-09-04 13:28                   ` Michael S. Tsirkin
2023-09-04 13:40                     ` Parav Pandit
2023-09-05  2:55                   ` Xuan Zhuo
2023-09-05  3:31                     ` Parav Pandit
2023-09-05  6:42                       ` Xuan Zhuo
2023-09-05  6:51                         ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1693817561.0941262-4-xuanzhuo@linux.alibaba.com \
    --to=xuanzhuo@linux.alibaba.com \
    --cc=david.edmondson@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox