Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Longpeng (Mike)" <longpeng2@huawei.com>
Cc: stefanha@redhat.com, pasic@linux.vnet.ibm.com,
	qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
	luonengjun@huawei.com, cohuck@redhat.com,
	denglingli@chinamobile.com, Jani.Kokkonen@huawei.com,
	Ola.Liljedahl@arm.com, Varun.Sethi@freescale.com,
	xin.zeng@intel.com, brian.a.keating@intel.com,
	liang.j.ma@intel.com, john.griffin@intel.com,
	weidong.huang@huawei.com, mike.caraman@nxp.com, agraf@suse.de,
	jasowang@redhat.com, nmorey@kalray.eu, vincent.jardin@6wind.com,
	arei.gonglei@hotmail.com, wangxinxin.wang@huawei.com
Subject: [virtio-dev] Re: [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
Date: Fri, 8 Sep 2017 07:31:42 +0300	[thread overview]
Message-ID: <20170908073027-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <59B21AE9.1090808@huawei.com>

On Fri, Sep 08, 2017 at 12:22:01PM +0800, Longpeng (Mike) wrote:
> 
> 
> On 2017/9/8 11:49, Michael S. Tsirkin wrote:
> 
> > On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote:
> >> Ping...
> >>
> >> Stefan, Halil, do you have any suggestion ?
> > 
> > I do not see this patchset in the virtio list archives.
> > It could be that youa re posting from an email that is
> > not a subscriber.
> > 
> > Please subscribe and repost.
> > 
> 
> 
> OK, I'll subscribe and repost after I complete the implementation based on the
> v19 :)

To clarify does not existing device in qemu work according to
this spec? We need to make the spec compatible with what's
out there in the field somehow (feature bit?).

> > We'll then have to allow up to 2 weeks for comments.
> > 
> > Halil, I hope this timing works for you.
> > 
> >> -- 
> >> Regards,
> >> Longpeng(Mike)
> >>
> >> On 2017/8/26 15:53, Longpeng(Mike) wrote:
> >>
> >>> Hi guys,
> >>>
> >>> I'll work on the virtio-crypto spec with Gonglei together, Because He is
> >>> so busy on the inner production project.
> >>>
> >>> ---
> >>> v19 -> v18:
> >>>  - fix some typos and grammar fixes [Stefan, Halil]
> >>>  - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE
> >>>  - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil]
> >>>  - refactor and redescribe the controlq/dataq request's format
> >>>    of mux mode. [Halil]
> >>>  - other small fixes. [Halil]
> >>>
> >>> v18 -> v17:
> >>>  - fix many English grammar problems suggested by Stefan, Thanks a lot!
> >>>
> >>> v17 -> v16:
> >>>  - Some grammar fixes [Stefan, Halil, Michael]
> >>>  - add a section named "Supported crypto services" in order to explain bit
> >>>    numbers and valuse clearly. [Halil, Cornelia]
> >>>  - avoid word reptition [Halil]
> >>>  - rename non-session mode to stateless mode [Halil]
> >>>  - change descriptions for all elements in struct virtio_crypto_config [Halil]
> >>>  - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
> >>>  - other fixes here and there.
> >>>
> >>> Changes since v15:
> >>>  - use feature bits for non-session mode in order to keep compatibility with
> >>>    pre-existing code. [Halil & Michael]
> >>>  - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other
> >>>    non-session mode feature bits.
> >>>  - fix some typos. [Stefan]
> >>>  - introduce struct virtio_crypto_op_data_req_mux to support both session
> >>>    and non-session based crypto operations and keep compatibility with
> >>>    pre-existing code.
> >>>
> >>> Changes since v14:
> >>>  - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
> >>>  - correct a sentence about dataqueue and controlq in the first paragraph. 
> >>> [Halil]
> >>>  - change a MAY to MUST about max_dataqueues. [Halil]
> >>>  - add non-session mode support
> >>>    a) add four features for different crypto services to identify wheather 
> >>> support session mode.
> >>>    b) rewrite some
> >>>
> >>> For pervious versions of virtio crypto spec, Pls see:
> >>>
> >>> [v18]:
> >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html
> >>>
> >>> [v14]:
> >>> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
> >>>
> >>> [v13]:
> >>> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
> >>>
> >>> For more information, please see:
> >>>  http://qemu-project.org/Features/VirtioCrypto
> >>>
> >>> ---
> >>> Gonglei (2):
> >>>   virtio-crypto: Add virtio crypto device specification
> >>>   virtio-crypto: Add conformance clauses
> >>>
> >>>  acknowledgements.tex |    3 +
> >>>  conformance.tex      |   29 +
> >>>  content.tex          |    2 +
> >>>  virtio-crypto.tex    | 1470 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >>>  4 files changed, 1504 insertions(+)
> >>>  create mode 100644 virtio-crypto.tex
> >>>
> >>
> >>
> >> -- 
> >> Regards,
> >> Longpeng(Mike)
> > 
> > .
> > 
> 
> 
> -- 
> Regards,
> Longpeng(Mike)

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2017-09-08  4:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-26  7:53 [PATCH v19 0/2] virtio-crypto: virtio crypto device specification Longpeng(Mike)
2017-08-26  7:53 ` [PATCH v19 1/2] virtio-crypto: Add " Longpeng(Mike)
2017-08-26  7:53 ` [PATCH v19 2/2] virtio-crypto: Add conformance clauses Longpeng(Mike)
2017-09-01  0:47 ` [PATCH v19 0/2] virtio-crypto: virtio crypto device specification Longpeng (Mike)
2017-09-01 11:45   ` [virtio-dev] Re: [Qemu-devel] " Halil Pasic
2017-09-02  1:52     ` Longpeng (Mike)
2017-09-06 13:52     ` [virtio-dev] " Michael S. Tsirkin
2017-09-06 14:12       ` Halil Pasic
2017-09-08  4:17       ` Longpeng (Mike)
2017-09-08  3:49   ` [virtio-dev] " Michael S. Tsirkin
2017-09-08  4:22     ` Longpeng (Mike)
2017-09-08  4:31       ` Michael S. Tsirkin [this message]
2017-09-08  6:32         ` Longpeng (Mike)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170908073027-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=Jani.Kokkonen@huawei.com \
    --cc=Ola.Liljedahl@arm.com \
    --cc=Varun.Sethi@freescale.com \
    --cc=agraf@suse.de \
    --cc=arei.gonglei@hotmail.com \
    --cc=brian.a.keating@intel.com \
    --cc=cohuck@redhat.com \
    --cc=denglingli@chinamobile.com \
    --cc=jasowang@redhat.com \
    --cc=john.griffin@intel.com \
    --cc=liang.j.ma@intel.com \
    --cc=longpeng2@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=mike.caraman@nxp.com \
    --cc=nmorey@kalray.eu \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vincent.jardin@6wind.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=wangxinxin.wang@huawei.com \
    --cc=weidong.huang@huawei.com \
    --cc=xin.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox