Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Sameeh Jubran <sameeh@daynix.com>
To: virtio-dev <virtio-dev@lists.oasis-open.org>
Subject: [virtio-dev] [PATCH] virtio-net: Add missing flag define to struct
Date: Thu, 21 Dec 2017 16:45:04 +0200	[thread overview]
Message-ID: <20171221144504.12747-1-sameeh@daynix.com> (raw)

From: sameehj <sameeh.j@gmail.com>

The flag VIRTIO_NET_HDR_F_DATA_VALID is aleady  mentioned in the virtio-net
spec however it is not defined in the struct. This flag is already defined
and used in virtio-net device in Qemu as well as some of it's drivers.
---
 content.tex | 1 +
 1 file changed, 1 insertion(+)

diff --git a/content.tex b/content.tex
index c840588..788d8b5 100644
--- a/content.tex
+++ b/content.tex
@@ -3305,6 +3305,7 @@ itself is preceded by a header:
 \begin{lstlisting}
 struct virtio_net_hdr {
 #define VIRTIO_NET_HDR_F_NEEDS_CSUM    1
+#define VIRTIO_NET_HDR_F_DATA_VALID    2
         u8 flags;
 #define VIRTIO_NET_HDR_GSO_NONE        0
 #define VIRTIO_NET_HDR_GSO_TCPV4       1
-- 
2.13.6


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


             reply	other threads:[~2017-12-21 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 14:45 Sameeh Jubran [this message]
2017-12-21 16:31 ` [virtio-dev] [PATCH] virtio-net: Add missing flag define to struct Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221144504.12747-1-sameeh@daynix.com \
    --to=sameeh@daynix.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox