Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
	virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Subject: [virtio] Re: [virtio-dev] Re: [PATCH 1/2] ccw: be more precise the semantic of revision 1
Date: Mon, 12 Feb 2018 23:09:05 +0200	[thread overview]
Message-ID: <20180212230733-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <e00a945e-49e4-4f2b-916e-90a2565b3b33@linux.vnet.ibm.com>

On Mon, Feb 12, 2018 at 03:25:12PM +0100, Halil Pasic wrote:
> 
> 
> On 02/12/2018 01:59 PM, Cornelia Huck wrote:
> > On Fri,  9 Feb 2018 20:59:13 +0100
> > Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> > 
> > s/precise/precise about/
> 
> Nod. Should I spin a v2 or is it better handled
> via fixup by maintainer?

I prefer a respin. How about that jira issue(s)?
You could then also include the # in the patch commit log then.
Just say

VIRTIO-XXXX

in the commit log

> > 
> >> Revision 1 of the CCW transport is currently defined as virtio 1.0. This
> >> could become confusing when we bump the version of the virtio
> >> specification to 1.1, in a sense that it could be interpreted like one
> >> can not use any features not part of the 1.0 specification.
> >>
> >> So let us try to avoid confusion regarding the semantic of virtio-ccw
> >> revision 1.
> >>
> >> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> >> ---
> >>  content.tex |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/content.tex b/content.tex
> >> index c7ef7fd..86044dd 100644
> >> --- a/content.tex
> >> +++ b/content.tex
> >> @@ -2572,7 +2572,7 @@ The following values are supported:
> >>  \hline \hline
> >>  0        & 0      & <empty>   & legacy interface; transitional devices only \\
> >>  \hline
> >> -1        & 0      & <empty>   & Virtio 1.0 \\
> >> +1        & 0      & <empty>   & Virtio 1 \\
> >>  \hline
> >>  2        & 0      & <empty>   & CCW_CMD_READ_STATUS support \\
> >>  \hline
> > 
> > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> 
> Thanks!
> 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> > 

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


  reply	other threads:[~2018-02-12 21:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 19:59 [virtio] [PATCH 0/2] two versioning related changes Halil Pasic
2018-02-09 19:59 ` [virtio] [PATCH 1/2] ccw: be more precise the semantic of revision 1 Halil Pasic
2018-02-12 12:59   ` [virtio] " Cornelia Huck
2018-02-12 14:25     ` [virtio] Re: [virtio-dev] " Halil Pasic
2018-02-12 21:09       ` Michael S. Tsirkin [this message]
2018-02-12 22:47         ` Halil Pasic
2018-02-09 19:59 ` [virtio] [PATCH 2/2] introduction: simplify the designation of legacy Halil Pasic
2018-02-12 13:00   ` [virtio] " Cornelia Huck
2018-02-09 20:43 ` [virtio] Re: [PATCH 0/2] two versioning related changes Michael S. Tsirkin
2018-02-12 13:03   ` Cornelia Huck
2018-02-12 14:29     ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212230733-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox