From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-3376-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 7E5A358180FF for ; Fri, 2 Mar 2018 09:57:37 -0800 (PST) Date: Fri, 2 Mar 2018 19:57:25 +0200 From: "Michael S. Tsirkin" Message-ID: <20180302195625-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [virtio-dev] Re: [PATCH 2/4] rocker: drop local duplex definitions To: Jason Baron Cc: jasowang@redhat.com, qemu-devel@nongnu.org, Jiri Pirko , virtio-dev@lists.oasis-open.org List-ID: On Thu, Mar 01, 2018 at 10:46:34PM -0500, Jason Baron wrote: > Make use of duplex definitions from net/eth.h. > > Signed-off-by: Jason Baron > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Jiri Pirko > Cc: virtio-dev@lists.oasis-open.org > --- > hw/net/rocker/rocker_fp.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/hw/net/rocker/rocker_fp.c b/hw/net/rocker/rocker_fp.c > index 4b3c984..13a14a0 100644 > --- a/hw/net/rocker/rocker_fp.c > +++ b/hw/net/rocker/rocker_fp.c > @@ -16,17 +16,13 @@ > > #include "qemu/osdep.h" > #include "net/clients.h" > +#include "net/eth.h" > > #include "rocker.h" > #include "rocker_hw.h" > #include "rocker_fp.h" > #include "rocker_world.h" > > -enum duplex { > - DUPLEX_HALF = 0, > - DUPLEX_FULL > -}; > - This is hardware emulation, so I actually suspect it should be renamed ROCKER_FP_HALF/ROCKER_FP_FULL. > struct fp_port { > Rocker *r; > World *world; > -- > 2.7.4 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org