Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: jiri@resnulli.us, stephen@networkplumber.org,
	alexander.h.duyck@intel.com, davem@davemloft.net,
	jesse.brandeburg@intel.com, kubakici@wp.pl, jasowang@redhat.com,
	sridhar.samudrala@intel.com, netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	virtio-dev@lists.oasis-open.org
Subject: [virtio-dev] Re: [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden
Date: Tue, 3 Apr 2018 15:20:27 +0300	[thread overview]
Message-ID: <20180403151915-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1522573990-5242-4-git-send-email-si-wei.liu@oracle.com>

On Sun, Apr 01, 2018 at 05:13:10AM -0400, Si-Wei Liu wrote:
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index aa40664..0827b7e 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -80,6 +80,8 @@ struct virtio_net_config {
>  	__u16 max_virtqueue_pairs;
>  	/* Default maximum transmit unit advice */
>  	__u16 mtu;
> +	/* Device at bus:slot.function backed up by virtio_net */
> +	__u16 bsf2backup;
>  } __attribute__((packed));

I'm not sure this is a good interface.  This isn't unique even on some
PCI systems, not to speak of non-PCI ones.

>  /*
> -- 
> 1.8.3.1

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2018-04-03 12:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-01  9:13 [virtio-dev] [RFC PATCH 0/3] Userspace compatible driver model for virtio_bypass Si-Wei Liu
2018-04-01  9:13 ` [virtio-dev] [RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device Si-Wei Liu
2018-04-03 12:25   ` [virtio-dev] " Michael S. Tsirkin
2018-04-04  8:02     ` Siwei Liu
     [not found]       ` <d666b8a9-9ff8-4a56-0faa-ef3d0bf81d25@redhat.com>
2018-04-07  2:54         ` Siwei Liu
2018-04-01  9:13 ` [virtio-dev] [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice Si-Wei Liu
     [not found]   ` <8b589cd2-1abc-59c2-99f1-96df8174bb6b@gmail.com>
2018-04-03  7:40     ` [virtio-dev] " Siwei Liu
     [not found]     ` <20180403154210.GK3313@nanopsycho>
2018-04-03 19:23       ` Siwei Liu
     [not found]       ` <3bdfc39f-4935-2433-7982-9ce28c3aa166@gmail.com>
2018-04-04  7:36         ` Siwei Liu
     [not found]           ` <54accf73-e6cc-e03f-6a1c-34e1bbd78047@gmail.com>
     [not found]             ` <20180404.133749.1802514210170809419.davem@davemloft.net>
2018-04-07  2:32               ` Siwei Liu
     [not found]                 ` <20180407031919.GB11029@lunn.ch>
2018-04-09 22:07                   ` Siwei Liu
     [not found]                     ` <20180409221523.GH562@lunn.ch>
2018-04-09 22:30                       ` Siwei Liu
     [not found]                         ` <20180409160348.12f8a6d9@xeon-e3>
2018-04-09 23:31                           ` Siwei Liu
     [not found]                 ` <20180408.123207.2294740686493951200.davem@davemloft.net>
2018-04-10  6:48                   ` Siwei Liu
2018-04-18  0:26                     ` Siwei Liu
2018-04-18 23:33                       ` Samudrala, Sridhar
2018-04-19  4:41                         ` Michael S. Tsirkin
2018-04-19  5:00                           ` Samudrala, Sridhar
2018-04-19  5:07                             ` Michael S. Tsirkin
2018-04-19  6:10                               ` Samudrala, Sridhar
2018-04-19  6:43                                 ` Siwei Liu
2018-04-19  6:31                             ` Siwei Liu
     [not found]         ` <20180404061945.GN3313@nanopsycho>
2018-04-04  8:01           ` Siwei Liu
2018-04-04  8:28         ` Siwei Liu
     [not found]   ` <20180403103536.6ec1450c@xeon-e3>
     [not found]     ` <CADGSJ23vZdtQzWdc_6M_Hr4MUej--wgvJ785DwRF3VaPWS1rpA@mail.gmail.com>
     [not found]       ` <20180403160834.51594373@xeon-e3>
2018-04-06 21:29         ` Siwei Liu
2018-04-01  9:13 ` [virtio-dev] [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden Si-Wei Liu
2018-04-03 12:20   ` Michael S. Tsirkin [this message]
2018-04-04  8:03     ` [virtio-dev] " Siwei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180403151915-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jiri@resnulli.us \
    --cc=kubakici@wp.pl \
    --cc=netdev@vger.kernel.org \
    --cc=si-wei.liu@oracle.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox