From: Sameeh Jubran <sameeh@daynix.com>
To: virtio-dev@lists.oasis-open.org
Cc: Amnon Ilan <ailan@redhat.com>, Yan Vugenfirer <yan@daynix.com>
Subject: [virtio-dev] [PATCH v3 1/2] content: net: Add VIRTIO_NET_F_CTRL_STEERING_MODE feature
Date: Wed, 18 Apr 2018 13:46:55 +0300 [thread overview]
Message-ID: <20180418104656.1450-2-sameeh@daynix.com> (raw)
In-Reply-To: <20180418104656.1450-1-sameeh@daynix.com>
From: Sameeh Jubran <sameeh.j@gmail.com>
This commit introduces steering mode into network device. Steering
mode is a general infrastructure for various steering modes that can
be implemented on top of it such as Automatic and RSS.
Signed-off-by: Sameeh Jubran <sjubran@redhat.com>
---
content.tex | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/content.tex b/content.tex
index c840588..6b1f7ca 100644
--- a/content.tex
+++ b/content.tex
@@ -3115,6 +3115,9 @@ features.
\item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)] Set MAC address through control
channel.
+
+\item[VIRTIO_NET_F_CTRL_STEERING_MODE(60)] Device supports configurable steering
+ mode.
\end{description}
\subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device / Feature bits / Feature bit requirements}
@@ -3317,6 +3320,8 @@ struct virtio_net_hdr {
le16 csum_start;
le16 csum_offset;
le16 num_buffers;
+// Only if VIRTIO_NET_F_CTRL_STEERING_MODE has been negotiated
+ le64 hash;
};
\end{lstlisting}
@@ -4013,6 +4018,62 @@ MUST format \field{virtqueue_pairs}
according to the native endian of the guest rather than
(necessarily when not using the legacy interface) little-endian.
+\paragraph{Steering mode}\label{sec:Device Types / Network Device / Device Operation / Control Virtqueue / Steering mode}
+
+\begin{lstlisting}
+// steering mode flags
+#define STEERING_MODE_AUTO 0x1
+
+// Used by the devide for returning to the driver the supported steering modes
+struct virtio_net_steering_modes {
+le32 steering_modes;
+};
+
+struct virtio_net_steering_mode {
+le32 steering_mode;
+le32 command;
+
+// A union which can be used for passing structures to one of the sub modes
+ union {
+ }
+};
+
+#define VIRTIO_NET_F_CTRL_STEERING_MODE 27
+
+#define VIRTIO_NET_CTRL_STEERING_MODE 7
+#define VIRTIO_NET_CTRL_SM_GET_SUPPORTED_MODES 0
+#define VIRTIO_NET_CTRL_SM_CONTROL 1
+\end{lstlisting}
+
+If the VIRTIO_NET_F_CTRL_STEERING_MODE is negotiated the driver can send control commands for the
+configuring the steering mode. There are multiple steering modes and they can be configured using
+the VIRTIO_NET_CTRL_SM_CONTROL command. Each mode has it's own set of commands.
+
+The auto steering mode is the default mode if nothing else has been configured by the driver
+and the VIRTIO_NET_F_CTRL_STEERING_MODE feature is acked by the driver.
+
+The class VIRTIO_NET_CTRL_STEERING_MODE has two commands:
+
+\begin{enumerate}
+
+\item VIRTIO_NET_CTRL_SM_GET_SUPPORTED_MODES is used for getting the supported steering modes by the device.
+ The command should be executed by the driver before attempting to configure the steering mode. Once the device
+ receives this command it should fill the virtio_net_steering_modes structure with the supported steering mode
+ flags.
+
+\item The command VIRTIO_NET_CTRL_SM_CONTROL is used for controlling the different steering modes. Each steering mode
+ has its own set of commands. When executing this command the structure virtio_net_steering_mode should be used as follows:
+ the \field{steering_mode} should be filled with one of the steering mode flags along with an appropriate command from the chosen
+ steering mode. The union of virtio_net_steering_mode should be used and filled as the mode's command suggests.
+\end{enumerate}
+
+If this feature has been negotiated, the virtio header has an additional
+\field{hash} field attached to it.
+
+\subparagraph{Automatic Receive Steering}{Device Types / Network Device / Device Operation / Control Virtqueue / Steering mode / Automatic Receive Steering}
+
+This is the default steering mode, please refer to the "Automatic receive steering in multiqueue" section.
+
\paragraph{Offloads State Configuration}\label{sec:Device Types / Network Device / Device Operation / Control Virtqueue / Offloads State Configuration}
If the VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature is negotiated, the driver can
--
2.13.6
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-04-18 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 10:46 [virtio-dev] [PATCH v3 0/2] Introducing RSS to virtio-net Sameeh Jubran
2018-04-18 10:46 ` Sameeh Jubran [this message]
2018-04-27 18:17 ` [virtio-dev] [PATCH v3 1/2] content: net: Add VIRTIO_NET_F_CTRL_STEERING_MODE feature Vijayabhaskar Balakrishna
2018-04-29 10:16 ` Sameeh Jubran
2018-04-18 10:46 ` [virtio-dev] [PATCH v3 2/2] content: net: steering mode: Add RSS Sameeh Jubran
2018-04-27 22:09 ` Vijayabhaskar Balakrishna
2018-04-29 10:23 ` Sameeh Jubran
2018-04-22 13:51 ` [virtio-dev] Re: [PATCH v3 0/2] Introducing RSS to virtio-net Sameeh Jubran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418104656.1450-2-sameeh@daynix.com \
--to=sameeh@daynix.com \
--cc=ailan@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox