Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jonathan Helman <jonathan.helman@oracle.com>
Cc: virtio-dev@lists.oasis-open.org, mihai.carabas@oracle.com,
	jasowang@redhat.com
Subject: [virtio-dev] Re: [PATCH] content: document hugetlb page allocation counts
Date: Wed, 18 Apr 2018 23:03:34 +0300	[thread overview]
Message-ID: <20180418224625-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1524071419-32187-1-git-send-email-jonathan.helman@oracle.com>

On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote:
> The Linux kernel exports the number of successful and failed
> hugetlb page allocations via the virtio balloon driver. These
> two counts need to be documented in this specification.
> 
> Signed-off-by: Jonathan Helman <jonathan.helman@oracle.com>

Thanks!
Would you mind opening a github issue to address that?
If you have to repost, you will be able to add a "Fixes:" tag
then.

> ---
>  content.tex | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/content.tex b/content.tex
> index 7a92cb1..110ab70 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -4516,6 +4516,8 @@ struct virtio_balloon_stat {
>  #define VIRTIO_BALLOON_S_MEMTOT   5
>  #define VIRTIO_BALLOON_S_AVAIL    6
>  #define VIRTIO_BALLOON_S_CACHES   7
> +#define VIRTIO_BALLOON_S_HTLB_PGALLOC 8
> +#define VIRTIO_BALLOON_S_HTLB_PGFAIL  9
>          le16 tag;
>          le64 val;
>  } __attribute__((packed));
> @@ -4604,6 +4606,12 @@ first buffer.
>  \item[VIRTIO_BALLOON_S_CACHES (7)] The amount of memory, in bytes, that can be
>    quickly reclaimed without additional I/O. Typically these pages are used for
>    caching files from disk.
> +
> +\item[VIRTIO_BALLOON_S_HTLB_PGALLOC (8)] The number of successful hugetlb page
> +  allocations in the guest.
> +
> +\item[VIRTIO_BALLOON_S_HTLB_PGFAIL (9)] The number of failed hugetlb page
> +  allocations in the guest.
>  \end{description}
>  
>  \section{SCSI Host Device}\label{sec:Device Types / SCSI Host Device}
> -- 
> 1.8.3.1

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2018-04-18 20:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 17:10 [virtio-dev] [PATCH] content: document hugetlb page allocation counts Jonathan Helman
2018-04-18 20:03 ` Michael S. Tsirkin [this message]
2018-04-18 21:16   ` [virtio-dev] " Jonathan Helman
2018-04-19  9:24 ` [virtio-dev] " Stefan Hajnoczi
2018-04-25 18:26   ` Jonathan Helman
2018-04-25 22:25     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418224625-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jonathan.helman@oracle.com \
    --cc=mihai.carabas@oracle.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox