From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4236-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id A303A1CB8078 for ; Fri, 1 Jun 2018 03:46:11 -0700 (PDT) Date: Fri, 1 Jun 2018 12:45:52 +0200 From: Cornelia Huck Message-ID: <20180601124552.6a188454.cohuck@redhat.com> In-Reply-To: <20180601102217.21628-1-tiwei.bie@intel.com> References: <20180601102217.21628-1-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [virtio-dev] [PATCH] virtio: update the comments for transport features To: Tiwei Bie Cc: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org List-ID: On Fri, 1 Jun 2018 18:22:17 +0800 Tiwei Bie wrote: > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > --- > This patch is generated on top of below patch: > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html > > include/uapi/linux/virtio_config.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h > index b7c1f4e7d59e..479affd903e9 100644 > --- a/include/uapi/linux/virtio_config.h > +++ b/include/uapi/linux/virtio_config.h > @@ -45,9 +45,12 @@ > /* We've given up on this device. */ > #define VIRTIO_CONFIG_S_FAILED 0x80 > > -/* Some virtio feature bits (currently bits 28 through 32) are reserved for the > - * transport being used (eg. virtio_ring), the rest are per-device feature > - * bits. */ > +/* > + * Some virtio feature bits (currently bits VIRTIO_TRANSPORT_F_START > + * through VIRTIO_TRANSPORT_F_END) are reserved for the transport being It will always be bits up to VIRTIO_TRANSPORT_F_END, no? So you can drop the "currently"? Or reword as "Virtio feature bits VIRTIO_TRANSPORT_F_START through VIRTIO_TRANSPORT_F_END are reserved..."? > + * used (e.g. virtio_ring, virtio_pci etc.), the rest are per-device > + * feature bits. > + */ > #define VIRTIO_TRANSPORT_F_START 28 > #define VIRTIO_TRANSPORT_F_END 38 > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org