From: Tiwei Bie <tiwei.bie@intel.com>
To: mst@redhat.com, cohuck@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, virtio-dev@lists.oasis-open.org
Cc: dan.daly@intel.com, cunming.liang@intel.com, zhihong.wang@intel.com
Subject: [virtio-dev] [PATCH] content: enhance device requirements for feature bits
Date: Fri, 8 Jun 2018 14:59:28 +0800 [thread overview]
Message-ID: <20180608065928.2456-1-tiwei.bie@intel.com> (raw)
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14
---
content.tex | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/content.tex b/content.tex
index f996fad..8374d3f 100644
--- a/content.tex
+++ b/content.tex
@@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset
of features the driver accepts, otherwise it MUST fail to set the
FEATURES_OK \field{device status} bit when the driver writes it.
+If a device has successfully negotiated a set of features
+at least once (by setting the FEATURES_OK \field{device
+status} bit when the driver writes it), then it SHOULD NOT
+fail re-negotiation of the same set of features after a
+device or system reset. Failure to do so would interfere
+with the resuming from suspend and error recovery.
+
\subsection{Legacy Interface: A Note on Feature
Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
Bits / Legacy Interface: A Note on Feature Bits}
--
2.17.0
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next reply other threads:[~2018-06-08 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 6:59 Tiwei Bie [this message]
2018-06-08 7:36 ` [virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits Cornelia Huck
2018-06-08 8:00 ` Tiwei Bie
2018-06-08 16:05 ` Michael S. Tsirkin
2018-06-11 7:11 ` Cornelia Huck
2018-06-11 7:50 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608065928.2456-1-tiwei.bie@intel.com \
--to=tiwei.bie@intel.com \
--cc=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox