Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
	cohuck@redhat.com, stefanha@redhat.com,
	denglingli@chinamobile.com, Jani.Kokkonen@huawei.com,
	Ola.Liljedahl@arm.com, Varun.Sethi@freescale.com,
	xin.zeng@intel.com, brian.a.keating@intel.com,
	liang.j.ma@intel.com, john.griffin@intel.com, agraf@suse.de,
	jasowang@redhat.com, vincent.jardin@6wind.com,
	arei.gonglei@huawei.com, pasic@linux.vnet.ibm.com,
	weidong.huang@huawei.com, wangxinxin.wang@huawei.com,
	jianjay.zhou@huawei.com
Subject: Re: [virtio-dev] [PATCH v25 0/2] virtio-crypto: virtio crypto device specification
Date: Fri, 7 Sep 2018 17:30:58 -0400	[thread overview]
Message-ID: <20180907173002-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1535071416-212072-1-git-send-email-longpeng2@huawei.com>

OK it is time to apply this.
If I do I get latex errors (undefined and multiple-defined
labels). Please post patches on top to fix this up,
I will squash.


On Fri, Aug 24, 2018 at 08:43:34AM +0800, Longpeng(Mike) wrote:
> ---
> v25 -> v24
>  - fix some typos and letex grammar.
> 
> v24 -> v23
>  - Some enhancements based on Halil's suggestion. [Halil]
> 
> v23 -> v22
>  - rename MUX_MODE to REVISION_1 [Halil]
>  - fixed-length paramenters' instead of 'header' and
>    'variable-length parameters' instead of 'extra parameters' [Halil]
>  - add guidance about VIRTIO_CRYPTO_FLAG_SESSION_MODE [Halil]
>  - other fixes. [Longpeng]
> 
> v22 -> v21
>  - fix some typos and grammar fixes [Halil, Stefan]
>  - reorder names in alphabetical order [Stefan]
>  - redescribe the date format [Halil]
> 
> v21 -> v20
>  - rename 'queue_id' to 'reserved' [Halil]
>  - redescribe the format of the structures which using 'union'
>    in the previous version [Halil]
> 
> v20 -> v19
>  - fix some typos and grammar fixes [Halil]
>  - make queue_id reserved [Halil]
>  - remove 'Steps of Operation'
> 
> v19 -> v18:
>  - fix some typos and grammar fixes [Stefan, Halil]
>  - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE
>  - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil]
>  - refactor and redescribe the controlq/dataq request's format
>    of mux mode. [Halil]
>  - other small fixes. [Halil]
> 
> v18 -> v17:
>  - fix many English grammar problems suggested by Stefan, Thanks a lot!
> 
> v17 -> v16:
>  - Some grammar fixes [Stefan, Halil, Michael]
>  - add a section named "Supported crypto services" in order to explain bit
>    numbers and valuse clearly. [Halil, Cornelia]
>  - avoid word reptition [Halil]
>  - rename non-session mode to stateless mode [Halil]
>  - change descriptions for all elements in struct virtio_crypto_config [Halil]
>  - add Halil as a reviewer in the ackonwledgement part, thanks for his work.
>  - other fixes here and there.
> 
> Changes since v15:
>  - use feature bits for non-session mode in order to keep compatibility with
>    pre-existing code. [Halil & Michael]
>  - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other
>    non-session mode feature bits.
>  - fix some typos. [Stefan]
>  - introduce struct virtio_crypto_op_data_req_mux to support both session
>    and non-session based crypto operations and keep compatibility with
>    pre-existing code.
> 
> Changes since v14:
>  - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia]
>  - correct a sentence about dataqueue and controlq in the first paragraph. 
> [Halil]
>  - change a MAY to MUST about max_dataqueues. [Halil]
>  - add non-session mode support
>    a) add four features for different crypto services to identify wheather 
> support session mode.
>    b) rewrite some
> 
> For pervious versions of virtio crypto spec, Pls see:
> 
> [v18]:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html
> 
> [v14]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html
> 
> [v13]:
> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html
> 
> For more information, please see:
>  http://qemu-project.org/Features/VirtioCrypto
> 
> Longpeng(Mike) (2):
>   virtio-crypto: Add virtio crypto device specification
>   virtio-crypto: Add conformance clauses
> 
>  acknowledgements.tex |    4 +
>  conformance.tex      |   29 +
>  content.tex          |    2 +
>  virtio-crypto.tex    | 1533 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 1568 insertions(+)
>  create mode 100644 virtio-crypto.tex
> 
> -- 
> 1.8.3.1
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2018-09-07 21:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24  0:43 [virtio-dev] [PATCH v25 0/2] virtio-crypto: virtio crypto device specification Longpeng(Mike)
2018-08-24  0:43 ` [virtio-dev] [PATCH v25 1/2] virtio-crypto: Add " Longpeng(Mike)
2018-08-24  0:43 ` [virtio-dev] [PATCH v25 2/2] virtio-crypto: Add conformance clauses Longpeng(Mike)
2018-08-24  0:51 ` [virtio-dev] Re: [PATCH v25 0/2] virtio-crypto: virtio crypto device specification Longpeng (Mike)
2018-08-24 11:23   ` Michael S. Tsirkin
2018-08-24 12:07     ` Gonglei (Arei)
2018-08-24 12:54       ` Michael S. Tsirkin
2018-08-28  3:31         ` Gonglei (Arei)
2018-08-28 12:12           ` Michael S. Tsirkin
2018-08-28 12:54             ` Gonglei (Arei)
2018-09-07 21:30 ` Michael S. Tsirkin [this message]
2018-09-10  0:54   ` [virtio-dev] " Longpeng (Mike)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907173002-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=Jani.Kokkonen@huawei.com \
    --cc=Ola.Liljedahl@arm.com \
    --cc=Varun.Sethi@freescale.com \
    --cc=agraf@suse.de \
    --cc=arei.gonglei@huawei.com \
    --cc=brian.a.keating@intel.com \
    --cc=cohuck@redhat.com \
    --cc=denglingli@chinamobile.com \
    --cc=jasowang@redhat.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=john.griffin@intel.com \
    --cc=liang.j.ma@intel.com \
    --cc=longpeng2@huawei.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vincent.jardin@6wind.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=wangxinxin.wang@huawei.com \
    --cc=weidong.huang@huawei.com \
    --cc=xin.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox