From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jens Freimann <jfreimann@redhat.com>,
virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org,
Tiwei Bie <tiwei.bie@intel.com>,
stefanha@redhat.com, pbonzini@redhat.com, jasowang@redhat.com,
pasic@linux.vnet.ibm.com, dan.daly@intel.com,
cunming.liang@intel.com, zhihong.wang@intel.com
Subject: [virtio] Re: [virtio-dev] [PATCH v3] ACCESS_PLATFORM/ORDER_PLATFORM
Date: Thu, 6 Dec 2018 15:09:04 +0100 [thread overview]
Message-ID: <20181206150904.0b0828b9.cohuck@redhat.com> (raw)
In-Reply-To: <20181206090046-mutt-send-email-mst@kernel.org>
On Thu, 6 Dec 2018 09:01:08 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Thu, Dec 06, 2018 at 01:24:32PM +0100, Jens Freimann wrote:
> > On Mon, Nov 26, 2018 at 08:03:37PM -0500, Michael S. Tsirkin wrote:
> > > + If this feature bit is negotiated, the ordering in effect for any
> > > + memory accesses by the driver that need to be ordered in a specific way
> > > + with respect to accesses by the device is the one suitable for devices
> > > + described by the platform.
> >
> > I had to read this sentence several times. How about: "Some memory
> > accesses by the driver need to be ordered in a specific way with
> > respect to accesses by the device. If this feature bit is negotiated,
> > these accesses need to match the ordering requirements of devices as
> > described for the platform."
> >
> > In any case:
> >
> > Reviewed-by: Jens Freimann <jfreimann@redhat.com>
>
> I think we can make this change under the trivial changes rule, thanks!
I agree, and I think that Jens' wording is easier to read.
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
next prev parent reply other threads:[~2018-12-06 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 1:03 [virtio] [PATCH v3] ACCESS_PLATFORM/ORDER_PLATFORM Michael S. Tsirkin
2018-12-06 12:24 ` [virtio] Re: [virtio-dev] " Jens Freimann
2018-12-06 14:01 ` Michael S. Tsirkin
2018-12-06 14:09 ` Cornelia Huck [this message]
2018-12-06 15:25 ` Halil Pasic
2018-12-06 18:16 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206150904.0b0828b9.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox