From: Cornelia Huck <cohuck@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, Vivek Goyal <vgoyal@redhat.com>,
Sage Weil <sweil@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Miklos Szeredi <mszeredi@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [virtio-dev] [VIRTIO RFC] content: add virtio file system device
Date: Wed, 12 Dec 2018 10:25:56 +0100 [thread overview]
Message-ID: <20181212102556.65bd43d3.cohuck@redhat.com> (raw)
In-Reply-To: <20181211125156.22523-1-stefanha@redhat.com>
On Tue, 11 Dec 2018 12:51:56 +0000
Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The work-in-progress virtio file system device transports Linux FUSE
> requests between a FUSE daemon running on the host and the FUSE driver
> inside the guest.
>
> This is an early version of the spec that maps FUSE requests to
> virtqueues. No changes are needed to the FUSE request format.
>
> Multiqueue is supported for normal requests. FUSE_INTERRUPT and
> FUSE_FORGET requests are only sent on the dedicated hiprio queue.
> Notifications are sent on the notifications queue.
>
> The FUSE driver currently works in a "pull" model where userspace reads
> requests from /dev/fuse one at a time. Virtqueues are a "push" model
> where the FUSE driver will need to enqueue requests onto a specific
> virtqueue and wait for the guest to process them.
>
> The request queue buffers are completed by the device when the request
> has been processed and struct fuse_out_header has been filled out. The
> FUSE driver then picks up the completed request and processes it as if
> the FUSE daemon had written to /dev/fuse.
>
> Notifications involve device-to-driver communication. Since virtqueues
> live in guest RAM, the device cannot initiate communication. Instead
> the notifications queue is populated with empty buffers by the FUSE
> driver (similar to a NIC rx queue). The device then "completes" a
> buffer when it wishes to notify the driver. Replies to the notification
> are place in a normal request queue, they do not go via the
> notifications queue.
>
> Note that this design assumes that the driver knows the required buffer
> size for each request. My understanding is that this is true in FUSE.
> The only exception is FUSE_NOTIFY_STORE, and even there the FUSE
> implementation has a limit of 32 pages, which makes for a natural buffer
> size limit for the notifications queue.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> The HTML version of this draft spec is available at
> https://stefanha.github.io/virtio/virtio-fs.html#x1-38800010.
>
> This is mostly for reference and serious review isn't necessary yet.
>
> For more information on virtio-fs, see https://virtio-fs.gitlab.io/.
>
> Once the implementation matures we will send a real VIRTIO spec patch.
>
> content.tex | 3 +
> introduction.tex | 3 +
> virtio-fs.tex | 208 +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 214 insertions(+)
> create mode 100644 virtio-fs.tex
>
> diff --git a/content.tex b/content.tex
> index b101d1b..4d38c5a 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2528,6 +2528,8 @@ Device ID & Virtio Device \\
> \hline
> 24 & Memory device \\
> \hline
> +26 & file system device \\
Would it make sense to go ahead and reserve this id now?
> +\hline
> \end{tabular}
>
> Some of the devices above are unspecified by this document,
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-12-12 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 12:51 [virtio-dev] [VIRTIO RFC] content: add virtio file system device Stefan Hajnoczi
2018-12-12 9:25 ` Cornelia Huck [this message]
2018-12-12 15:20 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212102556.65bd43d3.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mszeredi@redhat.com \
--cc=stefanha@redhat.com \
--cc=sweil@redhat.com \
--cc=swhiteho@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox