From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5530-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 709EE985D97 for ; Tue, 26 Feb 2019 17:44:08 +0000 (UTC) Date: Tue, 26 Feb 2019 18:44:00 +0100 From: Cornelia Huck Message-ID: <20190226184400.6fd52e3e.cohuck@redhat.com> In-Reply-To: <20190226180903.497cccaa.cohuck@redhat.com> References: <20190226162553.30231-1-stefanha@redhat.com> <20190226180903.497cccaa.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [virtio-dev] [PATCH] virtio-blk: clarify semantics of multi-segment discard/write zeroes commands To: Stefan Hajnoczi Cc: virtio-dev@lists.oasis-open.org, Jan Kiszka List-ID: On Tue, 26 Feb 2019 18:09:03 +0100 Cornelia Huck wrote: > On Tue, 26 Feb 2019 16:25:53 +0000 > Stefan Hajnoczi wrote: > > > Describe the failure case and maximum number of segments in a > > multi-segment discard/write zeroes command. > > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/34 > > Signed-off-by: Stefan Hajnoczi > > --- > > I would like to request a vote on this. > > Only one minor nit from me, below. > > > > > content.tex | 23 +++++++++++++++++++++-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/content.tex b/content.tex > > index c5fdc34..7bfcc78 100644 > > --- a/content.tex > > +++ b/content.tex > > @@ -3967,8 +3967,10 @@ read from the block device (in multiples of 512 bytes). VIRTIO_BLK_T_OUT > > requests write the contents of \field{data} to the block device (in multiples > > of 512 bytes). > > > > -The \field{data} used for discard or write zeroes command is described > > -by one or more virtio_blk_discard_write_zeroes structs: > > +The \field{data} used for discard or write zeroes commands consists of one or > > +more segments. The maximum number of segments is \field{max_discard_seg} for > > +discard commands and \field{max_write_zeroes_seg} for write zeroes commands. > > +Each segment is of form: > > Maybe s/of form/of the form/ ? ...and that is certainly a non-material change we could do on top. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org