Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Subject: [virtio] [PATCH v2] signal start and end of structures consistently
Date: Mon, 11 Mar 2019 14:18:48 -0400	[thread overview]
Message-ID: <20190311181809.7970-1-mst@redhat.com> (raw)

Make sure all structs have the format:

struct X {
...
};

VIRTIO-170

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes since v1:
	no text changes, fix typo in commit log reported by Cornelia

 content.tex    | 11 +++++------
 virtio-gpu.tex |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/content.tex b/content.tex
index 4180296..f40d4fc 100644
--- a/content.tex
+++ b/content.tex
@@ -5272,8 +5272,7 @@ The following commands are defined:
 #define VIRTIO_SCSI_T_TMF_QUERY_TASK           6
 #define VIRTIO_SCSI_T_TMF_QUERY_TASK_SET       7
 
-struct virtio_scsi_ctrl_tmf
-{
+struct virtio_scsi_ctrl_tmf {
         // Device-readable part
         le32 type;
         le32 subtype;
@@ -5281,7 +5280,7 @@ struct virtio_scsi_ctrl_tmf
         le64 id;
         // Device-writable part
         u8   response;
-}
+};
 
 /* command-specific response values */
 #define VIRTIO_SCSI_S_FUNCTION_COMPLETE        0
@@ -5328,7 +5327,7 @@ struct virtio_scsi_ctrl_an {
     // Device-writable part
     le32 event_actual;
     u8   response;
-}
+};
 
 #define VIRTIO_SCSI_EVT_ASYNC_OPERATIONAL_CHANGE  2
 #define VIRTIO_SCSI_EVT_ASYNC_POWER_MGMT          4
@@ -5363,7 +5362,7 @@ struct virtio_scsi_ctrl_an {
         // Device-writable part
         le32 event_actual;
         u8   response;
-}
+};
 \end{lstlisting}
 
   By sending this command, the driver asks the specified LUN to
@@ -5415,7 +5414,7 @@ struct virtio_scsi_event {
         le32 event;
         u8  lun[8];
         le32 reason;
-}
+};
 \end{lstlisting}
 
 The devices sets bit 31 in \field{event} to report lost events
diff --git a/virtio-gpu.tex b/virtio-gpu.tex
index 0cf2209..992d4e6 100644
--- a/virtio-gpu.tex
+++ b/virtio-gpu.tex
@@ -47,7 +47,7 @@ struct virtio_gpu_config {
         le32 events_clear;
         le32 num_scanouts;
         le32 reserved;
-}
+};
 \end{lstlisting}
 
 \subsubsection{Device configuration fields}
-- 
MST

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


             reply	other threads:[~2019-03-11 18:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 18:18 Michael S. Tsirkin [this message]
2019-03-11 22:54 ` [virtio] [PATCH v2] signal start and end of structures consistently Cornelia Huck
2019-03-13 15:49 ` [virtio] Re: [virtio-dev] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311181809.7970-1-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox