Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org, stefanha@redhat.com,
	cohuck@redhat.com
Cc: vgoyal@redhat.com
Subject: [virtio-comment] [PATCH v5 2/5] pci: Define id field
Date: Thu, 27 Jun 2019 20:28:27 +0100	[thread overview]
Message-ID: <20190627192830.5285-3-dgilbert@redhat.com> (raw)
In-Reply-To: <20190627192830.5285-1-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

For the virtio-fs device we require multiple large shared memory
regions.  Differentiate these by an 'id' field in the base capability.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 content.tex | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/content.tex b/content.tex
index 6433226..41926c0 100644
--- a/content.tex
+++ b/content.tex
@@ -651,7 +651,8 @@ \subsection{Virtio Structure PCI Capabilities}\label{sec:Virtio Transport Option
         u8 cap_len;     /* Generic PCI field: capability length */
         u8 cfg_type;    /* Identifies the structure. */
         u8 bar;         /* Where to find it. */
-        u8 padding[3];  /* Pad to full dword. */
+        u8 id;          /* Multiple capabilities of the same type */
+        u8 padding[2];  /* Pad to full dword. */
         le32 offset;    /* Offset within bar. */
         le32 length;    /* Length of the structure, in bytes. */
 };
@@ -716,6 +717,11 @@ \subsection{Virtio Structure PCI Capabilities}\label{sec:Virtio Transport Option
 
         Any other value is reserved for future use.
 
+\item[\field{id}]
+        Multiple capabilities of the same type can exist as long
+        as they each have a unique \field{id}.  The specific
+        meaning of the field is different for each device type.
+
 \item[\field{offset}]
         indicates where the structure begins relative to the base address associated
         with the BAR.  The alignment requirements of \field{offset} are indicated
-- 
2.21.0


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  parent reply	other threads:[~2019-06-27 19:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 19:28 [virtio-comment] [PATCH v5 0/5] Large shared memory regions Dr. David Alan Gilbert (git)
2019-06-27 19:28 ` [virtio-comment] [PATCH v5 1/5] shared memory: Define " Dr. David Alan Gilbert (git)
2019-07-03 13:13   ` [virtio-comment] " Cornelia Huck
2019-06-27 19:28 ` Dr. David Alan Gilbert (git) [this message]
2019-06-28 10:00   ` [virtio-comment] Re: [PATCH v5 2/5] pci: Define id field Cornelia Huck
2019-06-28 13:36     ` [virtio-comment] Re: [virtio-dev] " Dr. David Alan Gilbert
2019-07-03 13:04       ` Cornelia Huck
2019-07-10 17:45         ` Dr. David Alan Gilbert
2019-06-27 19:28 ` [virtio-comment] [PATCH v5 3/5] pci: Define virtio_pci_cap64 Dr. David Alan Gilbert (git)
2019-06-28 10:02   ` [virtio-comment] " Cornelia Huck
2019-06-27 19:28 ` [virtio-comment] [PATCH v5 4/5] shared memory: Define PCI capability Dr. David Alan Gilbert (git)
2019-07-03 13:23   ` [virtio-comment] " Cornelia Huck
2019-07-10 17:49     ` Dr. David Alan Gilbert
2019-06-27 19:28 ` [virtio-comment] [PATCH v5 5/5] shared memory: Define mmio registers Dr. David Alan Gilbert (git)
2019-07-03 13:26   ` [virtio-comment] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627192830.5285-3-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox