From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5866-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 57EB1985BBA for ; Fri, 19 Jul 2019 04:13:42 +0000 (UTC) From: Tiwei Bie Date: Fri, 19 Jul 2019 12:11:51 +0800 Message-Id: <20190719041151.31320-1-tiwei.bie@intel.com> Subject: [virtio-dev] [PATCH] content: explicitly document the VLAN filtering as best-effort To: virtio-dev@lists.oasis-open.org Cc: mst@redhat.com, cohuck@redhat.com, stefanha@redhat.com, jasowang@redhat.com List-ID: Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/47 Signed-off-by: Tiwei Bie Acked-by: Michael S. Tsirkin --- v1: - Add "Fixes:" tag; RFC link: https://lists.oasis-open.org/archives/virtio-dev/201907/msg00035.html content.tex | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/content.tex b/content.tex index 8f0498e..783322b 100644 --- a/content.tex +++ b/content.tex @@ -3530,6 +3530,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi If the driver negotiates the VIRTION_NET_F_CTRL_VLAN feature, it can control a VLAN filter table in the device. +\begin{note} +Similar to the MAC address based filtering, the VLAN filtering +is also best-effort: unwanted packets could still arrive. +\end{note} + \begin{lstlisting} #define VIRTIO_NET_CTRL_VLAN 2 #define VIRTIO_NET_CTRL_VLAN_ADD 0 -- 2.17.1 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org