Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>
Subject: Re: [virtio-dev] [PATCH] Fix ^= in example code
Date: Sat, 12 Oct 2019 12:56:45 -0400	[thread overview]
Message-ID: <20191012125617-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1170e604-7d65-1c97-33f7-741054ecf5e0@siemens.com>

On Fri, Oct 11, 2019 at 01:43:41PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Trying to escaping ^ here only leaves the backslash in the output.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks! I think this kind of typo can be merged with no need for votes,
we have a standing rule for typos.

> ---
>  packed-ring.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/packed-ring.tex b/packed-ring.tex
> index caf47a5..ea92543 100644
> --- a/packed-ring.tex
> +++ b/packed-ring.tex
> @@ -634,7 +634,7 @@ \subsubsection{Implementation Example}\label{sec:Basic Facilities of a Virtio De
>  
>          if (vq->next_avail >= vq->size) {
>                  vq->next_avail = 0;
> -                vq->avail_wrap_count \^= 1;
> +                vq->avail_wrap_count ^= 1;
>          }
>  }
>  vq->sgs[id] = sgs;
> @@ -727,7 +727,7 @@ \subsection{Receiving Used Buffers From The Device}\label{sec:Basic Facilities o
>          vq->next_used += sgs;
>          if (vq->next_used >= vq->size) {
>                  vq->next_used -= vq->size;
> -                vq->used_wrap_count \^= 1;
> +                vq->used_wrap_count ^= 1;
>          }
>  
>          free_id(vq, id);
> -- 
> 2.16.4
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


      reply	other threads:[~2019-10-12 16:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 11:43 [virtio-dev] [PATCH] Fix ^= in example code Jan Kiszka
2019-10-12 16:56 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191012125617-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox