From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-return-3405-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Mon, 25 Nov 2019 03:22:13 -0500 From: "Michael S. Tsirkin" Message-ID: <20191125032108-mutt-send-email-mst@kernel.org> References: <20191028161240.24806-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: Subject: Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline To: Jan Kiszka Cc: virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org List-ID: On Mon, Nov 25, 2019 at 07:41:09AM +0100, Jan Kiszka wrote: > On 28.10.19 17:12, Michael S. Tsirkin wrote: > > If a hardware implementation of virtio does not have > > the correct subsystem id, then drivers can't report > > ir properly, or detect and work around bugs. >=20 > s/ir/it. >=20 > Jan >=20 > > Change the requirement from MAY to SHOULD. > >=20 > > We can't make it a MUST since we did not require this > > historically. > >=20 > > Signed-off-by: Michael S. Tsirkin One thing I noticed is that for transitional devices, windows drivers bind to a specific vendor id. I guess we need to make this SHOULD for non-transitional only? > > --- > > content.tex | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/content.tex b/content.tex > > index 4bcb728..8f1518c 100644 > > --- a/content.tex > > +++ b/content.tex > > @@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio = Transport Options / Virtio Ov > > For example, the network card device with the Virtio Device ID 1 > > has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000= . > > -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflec= t > > +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD ref= lect > > the PCI Vendor and Device ID of the environment (for informational pu= rposes by the driver). > > Non-transitional devices SHOULD have a PCI Device ID in the range > >=20 >=20 > --=20 > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux --------------------------------------------------------------------- To unsubscribe from this mail list, you must leave the OASIS TC that=20 generates this mail. Follow this link to all your TCs in OASIS at: https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php=20