Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	virtio@lists.oasis-open.org, virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org
Subject: Re: [virtio] Re: [virtio-dev] [PATCH] content: add vendor specific cfg type
Date: Wed, 27 Nov 2019 08:23:44 -0500	[thread overview]
Message-ID: <20191127082230-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191127055432-mutt-send-email-mst@kernel.org>

On Wed, Nov 27, 2019 at 05:59:03AM -0500, Michael S. Tsirkin wrote:
> On Wed, Nov 27, 2019 at 08:59:56AM +0100, Cornelia Huck wrote:
> > On Mon, 25 Nov 2019 03:11:43 -0500
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > 
> > > On Mon, Nov 25, 2019 at 08:45:52AM +0100, Jan Kiszka wrote:
> > > > On 28.10.19 11:55, Michael S. Tsirkin wrote:  
> > > > > Vendors might want to add their own capability
> > > > > in the PCI capability list. However, Virtio already
> > > > > uses the vendor specific capability ID (0x09)
> > > > > for its own purposes.  
> > > > 
> > > > Did some vendor express that need, or do we only assume it so far? IOW: Do
> > > > we know at least once concrete use case?  
> > > 
> > > Good point, I should have added this in the log.
> > > 
> > > I know of a device that implements virtio and has a bug.
> > > 
> > > Device is a transitional one so can not have vendor specific
> > > subsystem IDs (that violates the SHOULD below. Do we want to qualify
> > > that this recommendation is for non-transitional devices?). While that
> > 
> > What about adding some notes on top that vendor specific subsystem IDs
> > are not for transitional devices? That would also catch the case in the
> > other update.


So how about I just skip the following chunk when I commit?

	+The device SHOULD present the PCI subsystem vendor ID matching
	+the device vendor, at offset 0x2C in its PCI configuration space
	+header.

that seems to belong to the other ballot that I have withdrawn.

Minor enough that I don't feel we need to redo the whole ballot,
right?.

-- 
MST


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 


  reply	other threads:[~2019-11-27 13:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 10:55 [virtio] [PATCH] content: add vendor specific cfg type Michael S. Tsirkin
2019-11-24 12:32 ` [virtio] " Michael S. Tsirkin
2019-11-25  7:45 ` [virtio] Re: [virtio-dev] " Jan Kiszka
2019-11-25  8:11   ` Michael S. Tsirkin
2019-11-27  7:59     ` Cornelia Huck
2019-11-27 10:59       ` Michael S. Tsirkin
2019-11-27 13:23         ` Michael S. Tsirkin [this message]
2019-11-27 14:43           ` Cornelia Huck
     [not found] ` <F1C6DEC9-5E4D-464A-A0C3-D8E625D53F7E@redhat.com>
2019-11-27 21:17   ` [virtio] Re: [virtio-comment] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127082230-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox